Skip to content

Commit

Permalink
spi/rockchip: call wait_for_idle() for the transfer to complete
Browse files Browse the repository at this point in the history
Suggested-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Addy Ke <addy.ke@rockchip.com>
Signed-off-by: Mark Brown <broonie@linaro.org>
  • Loading branch information
Addy Ke authored and Mark Brown committed Jul 11, 2014
1 parent 5dcc44e commit 2df08e7
Showing 1 changed file with 19 additions and 5 deletions.
24 changes: 19 additions & 5 deletions drivers/spi/spi-rockchip.c
Original file line number Diff line number Diff line change
Expand Up @@ -214,6 +214,18 @@ static inline void flush_fifo(struct rockchip_spi *rs)
readl_relaxed(rs->regs + ROCKCHIP_SPI_RXDR);
}

static inline void wait_for_idle(struct rockchip_spi *rs)
{
unsigned long timeout = jiffies + msecs_to_jiffies(5);

do {
if (!(readl_relaxed(rs->regs + ROCKCHIP_SPI_SR) & SR_BUSY))
return;
} while (time_before(jiffies, timeout));

dev_warn(rs->dev, "spi controller is in busy state!\n");
}

static u32 get_fifo_len(struct rockchip_spi *rs)
{
u32 fifo;
Expand Down Expand Up @@ -371,6 +383,10 @@ static int rockchip_spi_pio_transfer(struct rockchip_spi *rs)
cpu_relax();
} while (remain);

/* If tx, wait until the FIFO data completely. */
if (rs->tx)
wait_for_idle(rs);

return 0;
}

Expand All @@ -393,6 +409,9 @@ static void rockchip_spi_dma_txcb(void *data)
unsigned long flags;
struct rockchip_spi *rs = data;

/* Wait until the FIFO data completely. */
wait_for_idle(rs);

spin_lock_irqsave(&rs->lock, flags);

rs->state &= ~TXBUSY;
Expand Down Expand Up @@ -536,11 +555,6 @@ static int rockchip_spi_transfer_one(
rs->tx_sg = xfer->tx_sg;
rs->rx_sg = xfer->rx_sg;

/* Delay until the FIFO data completely */
if (xfer->tx_buf)
xfer->delay_usecs
= rs->fifo_len * rs->bpw * 1000000 / rs->speed;

if (rs->tx && rs->rx)
rs->tmode = CR0_XFM_TR;
else if (rs->tx)
Expand Down

0 comments on commit 2df08e7

Please sign in to comment.