Skip to content

Commit

Permalink
[SCSI] osd_uld: Remove creation of osd_scsi class symlink
Browse files Browse the repository at this point in the history
Remove the creation of the symlink from the device to
it's class. On modern systems this is already created by
a udev rule and would WARN on load. On old systems it is
not needed, none of the current osd user-mode tools use
this link.

Signed-off-by: Boaz Harrosh <bharrosh@panasas.com>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
  • Loading branch information
Boaz Harrosh authored and James Bottomley committed Apr 3, 2009
1 parent 8c0bacc commit 2df71b1
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions drivers/scsi/osd/osd_uld.c
Original file line number Diff line number Diff line change
Expand Up @@ -345,10 +345,6 @@ static int osd_probe(struct device *dev)
}

dev_set_drvdata(oud->class_member, oud);
error = sysfs_create_link(&scsi_device->sdev_gendev.kobj,
&oud->class_member->kobj, osd_symlink);
if (error)
OSD_ERR("warning: unable to make symlink\n");

OSD_INFO("osd_probe %s\n", disk->disk_name);
return 0;
Expand Down Expand Up @@ -377,8 +373,6 @@ static int osd_remove(struct device *dev)
scsi_device);
}

sysfs_remove_link(&oud->od.scsi_device->sdev_gendev.kobj, osd_symlink);

if (oud->class_member)
device_destroy(osd_sysfs_class,
MKDEV(SCSI_OSD_MAJOR, oud->minor));
Expand Down

0 comments on commit 2df71b1

Please sign in to comment.