Skip to content

Commit

Permalink
regulator: max8998: Use simple equation to get selector
Browse files Browse the repository at this point in the history
It's more efficient to get the best selector by simple equation.

Signed-off-by: Axel Lin <axel.lin@gmail.com>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
  • Loading branch information
Axel Lin authored and Mark Brown committed Apr 10, 2012
1 parent 2358b77 commit 2e42a7d
Showing 1 changed file with 10 additions and 9 deletions.
19 changes: 10 additions & 9 deletions drivers/regulator/max8998.c
Original file line number Diff line number Diff line change
Expand Up @@ -306,8 +306,7 @@ static int max8998_set_voltage_ldo(struct regulator_dev *rdev,
int min_vol = min_uV / 1000, max_vol = max_uV / 1000;
const struct voltage_map_desc *desc;
int ldo = rdev_get_id(rdev);
int reg, shift = 0, mask, ret;
int i = 0;
int reg, shift = 0, mask, ret, i;

if (ldo >= ARRAY_SIZE(ldo_voltage_map))
return -EINVAL;
Expand All @@ -319,9 +318,10 @@ static int max8998_set_voltage_ldo(struct regulator_dev *rdev,
if (max_vol < desc->min || min_vol > desc->max)
return -EINVAL;

while (desc->min + desc->step*i < min_vol &&
desc->min + desc->step*i < desc->max)
i++;
if (min_vol < desc->min)
min_vol = desc->min;

i = DIV_ROUND_UP(min_vol - desc->min, desc->step);

if (desc->min + desc->step*i > max_vol)
return -EINVAL;
Expand Down Expand Up @@ -359,7 +359,7 @@ static int max8998_set_voltage_buck(struct regulator_dev *rdev,
const struct voltage_map_desc *desc;
int buck = rdev_get_id(rdev);
int reg, shift = 0, mask, ret;
int difference = 0, i = 0, j = 0, previous_vol = 0;
int difference = 0, i, j = 0, previous_vol = 0;
u8 val = 0;
static u8 buck1_last_val;

Expand All @@ -374,9 +374,10 @@ static int max8998_set_voltage_buck(struct regulator_dev *rdev,
if (max_vol < desc->min || min_vol > desc->max)
return -EINVAL;

while (desc->min + desc->step*i < min_vol &&
desc->min + desc->step*i < desc->max)
i++;
if (min_vol < desc->min)
min_vol = desc->min;

i = DIV_ROUND_UP(min_vol - desc->min, desc->step);

if (desc->min + desc->step*i > max_vol)
return -EINVAL;
Expand Down

0 comments on commit 2e42a7d

Please sign in to comment.