Skip to content

Commit

Permalink
mfd: arizona: Use correct type ID for device tree config
Browse files Browse the repository at this point in the history
In the case of a device tree config the code uses the device ID
from the DT entry to check which codec is required but when storing
the ID into struct arizona it was always using the non-DT SPI device
table to get an ID.

This patch changes the code to store the correct ID into struct arizona.

Signed-off-by: Richard Fitzgerald <rf@opensource.wolfsonmicro.com>
Acked-by: Lee Jones <lee.jones@linaro.org>
Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
  • Loading branch information
Richard Fitzgerald authored and Lee Jones committed Oct 30, 2015
1 parent b61c1ec commit 2e44e28
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 6 deletions.
5 changes: 2 additions & 3 deletions drivers/mfd/arizona-i2c.c
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,7 @@ static int arizona_i2c_probe(struct i2c_client *i2c,
regmap_config = &wm8998_i2c_regmap;
break;
default:
dev_err(&i2c->dev, "Unknown device type %ld\n",
id->driver_data);
dev_err(&i2c->dev, "Unknown device type %ld\n", type);
return -EINVAL;
}

Expand All @@ -79,7 +78,7 @@ static int arizona_i2c_probe(struct i2c_client *i2c,
return ret;
}

arizona->type = id->driver_data;
arizona->type = type;
arizona->dev = &i2c->dev;
arizona->irq = i2c->irq;

Expand Down
5 changes: 2 additions & 3 deletions drivers/mfd/arizona-spi.c
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,7 @@ static int arizona_spi_probe(struct spi_device *spi)
regmap_config = &wm5110_spi_regmap;
break;
default:
dev_err(&spi->dev, "Unknown device type %ld\n",
id->driver_data);
dev_err(&spi->dev, "Unknown device type %ld\n", type);
return -EINVAL;
}

Expand All @@ -70,7 +69,7 @@ static int arizona_spi_probe(struct spi_device *spi)
return ret;
}

arizona->type = id->driver_data;
arizona->type = type;
arizona->dev = &spi->dev;
arizona->irq = spi->irq;

Expand Down

0 comments on commit 2e44e28

Please sign in to comment.