Skip to content

Commit

Permalink
[SCSI] make blk layer set REQ_SOFTBARRIER on defer and requeue
Browse files Browse the repository at this point in the history
This is the reworked version of the patch.  It sets REQ_SOFTBARRIER
in two places - in elv_next_request() on BLKPREP_DEFER and in
blk_requeue_request().

Signed-off-by: Tejun Heo <htejun@gmail.com>
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
  • Loading branch information
Tejun Heo authored and James Bottomley committed May 20, 2005
1 parent 354d6b2 commit 2e759cd
Showing 1 changed file with 13 additions and 0 deletions.
13 changes: 13 additions & 0 deletions drivers/block/elevator.c
Original file line number Diff line number Diff line change
Expand Up @@ -290,6 +290,13 @@ void elv_requeue_request(request_queue_t *q, struct request *rq)
rq = rq->end_io_data;
}

/*
* the request is prepped and may have some resources allocated.
* allowing unprepped requests to pass this one may cause resource
* deadlock. turn on softbarrier.
*/
rq->flags |= REQ_SOFTBARRIER;

/*
* if iosched has an explicit requeue hook, then use that. otherwise
* just put the request at the front of the queue
Expand Down Expand Up @@ -386,6 +393,12 @@ struct request *elv_next_request(request_queue_t *q)
if (ret == BLKPREP_OK) {
break;
} else if (ret == BLKPREP_DEFER) {
/*
* the request may have been (partially) prepped.
* we need to keep this request in the front to
* avoid resource deadlock. turn on softbarrier.
*/
rq->flags |= REQ_SOFTBARRIER;
rq = NULL;
break;
} else if (ret == BLKPREP_KILL) {
Expand Down

0 comments on commit 2e759cd

Please sign in to comment.