Skip to content

Commit

Permalink
modpost: Fix resource leak in read_dump()
Browse files Browse the repository at this point in the history
Function read_dump() memory maps the input via grab_file(), but fails to call
the corresponding unmap function. Add the missing call to release_file().
Detected by Coverity: CID 1192419

Signed-off-by: Christian Engelmayer <cengelma@gmx.at>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
  • Loading branch information
Christian Engelmayer authored and Rusty Russell committed Apr 28, 2014
1 parent ec6931b commit 2ee41e6
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions scripts/mod/modpost.c
Original file line number Diff line number Diff line change
Expand Up @@ -2113,8 +2113,10 @@ static void read_dump(const char *fname, unsigned int kernel)
s->preloaded = 1;
sym_update_crc(symname, mod, crc, export_no(export));
}
release_file(file, size);
return;
fail:
release_file(file, size);
fatal("parse error in symbol dump file\n");
}

Expand Down

0 comments on commit 2ee41e6

Please sign in to comment.