Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 7601
b: refs/heads/master
c: 592cb26
h: refs/heads/master
i:
  7599: a0e8f58
v: v3
  • Loading branch information
Christoph Hellwig authored and Nathan Scott committed Sep 2, 2005
1 parent abb4171 commit 2ee59cc
Show file tree
Hide file tree
Showing 4 changed files with 2 additions and 74 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: 760dea671ea9c5b8c732d76d09673d6d052a186f
refs/heads/master: 592cb26bda6fe69838529acf71e50a6dee7acbb4
59 changes: 1 addition & 58 deletions trunk/fs/xfs/linux-2.6/xfs_vnode.c
Original file line number Diff line number Diff line change
Expand Up @@ -78,10 +78,6 @@ vn_reclaim(
}
ASSERT(vp->v_fbhv == NULL);

VN_LOCK(vp);
vp->v_flag &= (VRECLM|VWAIT);
VN_UNLOCK(vp, 0);

vp->v_fbhv = NULL;

#ifdef XFS_VNODE_TRACE
Expand All @@ -92,31 +88,6 @@ vn_reclaim(
return 0;
}

STATIC void
vn_wakeup(
struct vnode *vp)
{
VN_LOCK(vp);
if (vp->v_flag & VWAIT)
sv_broadcast(vptosync(vp));
vp->v_flag &= ~(VRECLM|VWAIT|VMODIFIED);
VN_UNLOCK(vp, 0);
}

int
vn_wait(
struct vnode *vp)
{
VN_LOCK(vp);
if (vp->v_flag & (VINACT | VRECLM)) {
vp->v_flag |= VWAIT;
sv_wait(vptosync(vp), PINOD, &vp->v_lock, 0);
return 1;
}
VN_UNLOCK(vp, 0);
return 0;
}

struct vnode *
vn_initialize(
struct inode *inode)
Expand Down Expand Up @@ -221,7 +192,6 @@ vn_purge(
{
vn_trace_entry(vp, "vn_purge", (inst_t *)__return_address);

again:
/*
* Check whether vp has already been reclaimed since our caller
* sampled its version while holding a filesystem cache lock that
Expand All @@ -233,19 +203,6 @@ vn_purge(
return;
}

/*
* If vp is being reclaimed or inactivated, wait until it is inert,
* then proceed. Can't assume that vnode is actually reclaimed
* just because the reclaimed flag is asserted -- a vn_alloc
* reclaim can fail.
*/
if (vp->v_flag & (VINACT | VRECLM)) {
ASSERT(vn_count(vp) == 0);
vp->v_flag |= VWAIT;
sv_wait(vptosync(vp), PINOD, &vp->v_lock, 0);
goto again;
}

/*
* Another process could have raced in and gotten this vnode...
*/
Expand All @@ -255,7 +212,6 @@ vn_purge(
}

XFS_STATS_DEC(vn_active);
vp->v_flag |= VRECLM;
VN_UNLOCK(vp, 0);

/*
Expand All @@ -266,11 +222,6 @@ vn_purge(
*/
if (vn_reclaim(vp) != 0)
panic("vn_purge: cannot reclaim");

/*
* Wakeup anyone waiting for vp to be reclaimed.
*/
vn_wakeup(vp);
}

/*
Expand Down Expand Up @@ -315,11 +266,6 @@ vn_rele(
* return.
*/
if (!vcnt) {
/*
* As soon as we turn this on, noone can find us in vn_get
* until we turn off VINACT or VRECLM
*/
vp->v_flag |= VINACT;
VN_UNLOCK(vp, 0);

/*
Expand All @@ -330,10 +276,7 @@ vn_rele(
VOP_INACTIVE(vp, NULL, cache);

VN_LOCK(vp);
if (vp->v_flag & VWAIT)
sv_broadcast(vptosync(vp));

vp->v_flag &= ~(VINACT|VWAIT|VRECLM|VMODIFIED);
vp->v_flag &= ~VMODIFIED;
}

VN_UNLOCK(vp, 0);
Expand Down
4 changes: 0 additions & 4 deletions trunk/fs/xfs/linux-2.6/xfs_vnode.h
Original file line number Diff line number Diff line change
Expand Up @@ -135,9 +135,6 @@ typedef enum {
/*
* Vnode flags.
*/
#define VINACT 0x1 /* vnode is being inactivated */
#define VRECLM 0x2 /* vnode is being reclaimed */
#define VWAIT 0x4 /* waiting for VINACT/VRECLM to end */
#define VMODIFIED 0x8 /* XFS inode state possibly differs */
/* to the Linux inode state. */

Expand Down Expand Up @@ -489,7 +486,6 @@ typedef struct vattr {
(VN_ISREG(vp) && ((mode) & (VSGID|(VEXEC>>3))) == VSGID)

extern void vn_init(void);
extern int vn_wait(struct vnode *);
extern vnode_t *vn_initialize(struct inode *);

/*
Expand Down
11 changes: 0 additions & 11 deletions trunk/fs/xfs/xfs_iget.c
Original file line number Diff line number Diff line change
Expand Up @@ -505,7 +505,6 @@ xfs_iget(
vnode_t *vp = NULL;
int error;

retry:
XFS_STATS_INC(xs_ig_attempts);

if ((inode = iget_locked(XFS_MTOVFS(mp)->vfs_super, ino))) {
Expand All @@ -526,16 +525,6 @@ xfs_iget(
iput(inode);
}
} else {
/* These are true if the inode is in inactive or
* reclaim. The linux inode is about to go away,
* wait for that path to finish, and try again.
*/
if (vp->v_flag & (VINACT | VRECLM)) {
vn_wait(vp);
iput(inode);
goto retry;
}

if (is_bad_inode(inode)) {
iput(inode);
return EIO;
Expand Down

0 comments on commit 2ee59cc

Please sign in to comment.