Skip to content

Commit

Permalink
module: turn longs into ints for module sizes
Browse files Browse the repository at this point in the history
This shrinks module.o and each *.ko file.

And finally, structure members which hold length of module
code (four such members there) and count of symbols
are converted from longs to ints.

We cannot possibly have a module where 32 bits won't
be enough to hold such counts.

For one, module loading checks module size for sanity
before loading, so such insanely big module will fail
that test first.

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
  • Loading branch information
Denys Vlasenko authored and Rusty Russell committed Jul 22, 2008
1 parent f7f5b67 commit 2f0f2a3
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
6 changes: 3 additions & 3 deletions include/linux/module.h
Original file line number Diff line number Diff line change
Expand Up @@ -288,10 +288,10 @@ struct module
void *module_core;

/* Here are the sizes of the init and core sections */
unsigned long init_size, core_size;
unsigned int init_size, core_size;

/* The size of the executable code in each section. */
unsigned long init_text_size, core_text_size;
unsigned int init_text_size, core_text_size;

/* The handle returned from unwind_add_table. */
void *unwind_info;
Expand All @@ -311,7 +311,7 @@ struct module
#ifdef CONFIG_KALLSYMS
/* We keep the symbol and string tables for kallsyms. */
Elf_Sym *symtab;
unsigned long num_symtab;
unsigned int num_symtab;
char *strtab;

/* Section attributes */
Expand Down
4 changes: 2 additions & 2 deletions kernel/module.c
Original file line number Diff line number Diff line change
Expand Up @@ -1567,7 +1567,7 @@ static int simplify_symbols(Elf_Shdr *sechdrs,
}

/* Update size with this section: return offset. */
static long get_offset(unsigned long *size, Elf_Shdr *sechdr)
static long get_offset(unsigned int *size, Elf_Shdr *sechdr)
{
long ret;

Expand Down Expand Up @@ -2562,7 +2562,7 @@ static int m_show(struct seq_file *m, void *p)
struct module *mod = list_entry(p, struct module, list);
char buf[8];

seq_printf(m, "%s %lu",
seq_printf(m, "%s %u",
mod->name, mod->init_size + mod->core_size);
print_unload_info(m, mod);

Expand Down

0 comments on commit 2f0f2a3

Please sign in to comment.