Skip to content

Commit

Permalink
vsprintf: use WARN_ON_ONCE
Browse files Browse the repository at this point in the history
Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com>
Reviewed-by: Frederic Weisbecker <fweisbec@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Marcin Slusarz authored and Linus Torvalds committed Sep 22, 2009
1 parent efc03ec commit 2f30b1f
Showing 1 changed file with 2 additions and 12 deletions.
14 changes: 2 additions & 12 deletions lib/vsprintf.c
Original file line number Diff line number Diff line change
Expand Up @@ -1092,13 +1092,8 @@ int vsnprintf(char *buf, size_t size, const char *fmt, va_list args)

/* Reject out-of-range values early. Large positive sizes are
used for unknown buffer sizes. */
if (unlikely((int) size < 0)) {
/* There can be only one.. */
static char warn = 1;
WARN_ON(warn);
warn = 0;
if (WARN_ON_ONCE((int) size < 0))
return 0;
}

str = buf;
end = buf + size;
Expand Down Expand Up @@ -1544,13 +1539,8 @@ int bstr_printf(char *buf, size_t size, const char *fmt, const u32 *bin_buf)

struct printf_spec spec = {0};

if (unlikely((int) size < 0)) {
/* There can be only one.. */
static char warn = 1;
WARN_ON(warn);
warn = 0;
if (WARN_ON_ONCE((int) size < 0))
return 0;
}

str = buf;
end = buf + size;
Expand Down

0 comments on commit 2f30b1f

Please sign in to comment.