Skip to content

Commit

Permalink
jbd2: remove outdated comment
Browse files Browse the repository at this point in the history
The comment about credit estimates isn't true anymore. We do what the
comment describes now.

Reviewed-by: Zheng Liu <wenqing.lz@taobao.com>
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
  • Loading branch information
Jan Kara authored and Theodore Ts'o committed Jun 4, 2013
1 parent b34090e commit 2f387f8
Showing 1 changed file with 0 additions and 10 deletions.
10 changes: 0 additions & 10 deletions fs/jbd2/transaction.c
Original file line number Diff line number Diff line change
Expand Up @@ -283,16 +283,6 @@ static int start_this_handle(journal_t *journal, handle_t *handle,
* reduce the free space arbitrarily. Be careful to account for
* those buffers when checkpointing.
*/

/*
* @@@ AKPM: This seems rather over-defensive. We're giving commit
* a _lot_ of headroom: 1/4 of the journal plus the size of
* the committing transaction. Really, we only need to give it
* committing_transaction->t_outstanding_credits plus "enough" for
* the log control blocks.
* Also, this test is inconsistent with the matching one in
* jbd2_journal_extend().
*/
if (__jbd2_log_space_left(journal) < jbd_space_needed(journal)) {
jbd_debug(2, "Handle %p waiting for checkpoint...\n", handle);
atomic_sub(nblocks, &transaction->t_outstanding_credits);
Expand Down

0 comments on commit 2f387f8

Please sign in to comment.