Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 318063
b: refs/heads/master
c: ad37c85
h: refs/heads/master
i:
  318061: 4213180
  318059: 23c63c6
  318055: cc8c7fc
  318047: 72019d9
v: v3
  • Loading branch information
H Hartley Sweeten authored and Greg Kroah-Hartman committed Jul 19, 2012
1 parent 5915b18 commit 2f75be9
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 12 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: 5f5d1b9ac13d44f370a3f7ebfc624b7f6cca4c19
refs/heads/master: ad37c85c44bd9b40028c2338c7e1a7e9be3dbd70
25 changes: 14 additions & 11 deletions trunk/drivers/staging/comedi/drivers/adv_pci1710.c
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,6 @@ static const struct boardtype boardtypes[] = {
};

struct pci1710_private {
struct pci_dev *pcidev; /* ptr to PCI device */
char valid; /* card is usable */
char neverending_ai; /* we do unlimited AI */
unsigned int CntrlReg; /* Control register */
Expand Down Expand Up @@ -1378,6 +1377,7 @@ static struct pci_dev *pci1710_find_pci_dev(struct comedi_device *dev,
static int pci1710_attach(struct comedi_device *dev,
struct comedi_devconfig *it)
{
struct pci_dev *pcidev;
struct comedi_subdevice *s;
int ret, subdev, n_subdevices;
unsigned int irq;
Expand All @@ -1388,16 +1388,17 @@ static int pci1710_attach(struct comedi_device *dev,
if (ret < 0)
return -ENOMEM;

devpriv->pcidev = pci1710_find_pci_dev(dev, it);
if (!devpriv->pcidev)
pcidev = pci1710_find_pci_dev(dev, it);
if (!pcidev)
return -EIO;
comedi_set_hw_dev(dev, &pcidev->dev);

ret = comedi_pci_enable(devpriv->pcidev, DRV_NAME);
ret = comedi_pci_enable(pcidev, DRV_NAME);
if (ret)
return ret;

dev->iobase = pci_resource_start(devpriv->pcidev, 2);
irq = devpriv->pcidev->irq;
dev->iobase = pci_resource_start(pcidev, 2);
irq = pcidev->irq;

dev->board_name = this_board->name;

Expand Down Expand Up @@ -1532,16 +1533,18 @@ static int pci1710_attach(struct comedi_device *dev,

static void pci1710_detach(struct comedi_device *dev)
{
struct pci_dev *pcidev = comedi_to_pci_dev(dev);

if (dev->private) {
if (devpriv->valid)
pci1710_reset(dev);
if (dev->irq)
free_irq(dev->irq, dev);
if (devpriv->pcidev) {
if (dev->iobase)
comedi_pci_disable(devpriv->pcidev);
pci_dev_put(devpriv->pcidev);
}
}
if (pcidev) {
if (dev->iobase)
comedi_pci_disable(pcidev);
pci_dev_put(pcidev);
}
}

Expand Down

0 comments on commit 2f75be9

Please sign in to comment.