Skip to content

Commit

Permalink
powerpc/powermac: Fix build error seen with powermac smp builds
Browse files Browse the repository at this point in the history
powermac smp builds fail with

arch/powerpc/platforms/powermac/smp.c: In function 'smp_psurge_probe':
arch/powerpc/platforms/powermac/smp.c:278:3: error:
		'return' with a value, in function returning void

There are several instances of this error.

Fixes: a7f4ee1 ("powerpc: Drop return value of smp_ops->probe()")
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
  • Loading branch information
Guenter Roeck authored and Michael Ellerman committed Apr 15, 2015
1 parent 16e00f5 commit 2fe0753
Showing 1 changed file with 4 additions and 6 deletions.
10 changes: 4 additions & 6 deletions arch/powerpc/platforms/powermac/smp.c
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,7 @@ static void __init smp_psurge_probe(void)

/* We don't do SMP on the PPC601 -- paulus */
if (PVR_VER(mfspr(SPRN_PVR)) == 1)
return 1;
return;

/*
* The powersurge cpu board can be used in the generation
Expand All @@ -289,7 +289,7 @@ static void __init smp_psurge_probe(void)
*/
dn = of_find_node_by_name(NULL, "hammerhead");
if (dn == NULL)
return 1;
return;
of_node_put(dn);

hhead_base = ioremap(HAMMERHEAD_BASE, 0x800);
Expand All @@ -310,13 +310,13 @@ static void __init smp_psurge_probe(void)
/* not a dual-cpu card */
iounmap(hhead_base);
psurge_type = PSURGE_NONE;
return 1;
return;
}
ncpus = 2;
}

if (psurge_secondary_ipi_init())
return 1;
return;

psurge_start = ioremap(PSURGE_START, 4);
psurge_pri_intr = ioremap(PSURGE_PRI_INTR, 4);
Expand All @@ -332,8 +332,6 @@ static void __init smp_psurge_probe(void)
set_cpu_present(i, true);

if (ppc_md.progress) ppc_md.progress("smp_psurge_probe - done", 0x352);

return ncpus;
}

static int __init smp_psurge_kick_cpu(int nr)
Expand Down

0 comments on commit 2fe0753

Please sign in to comment.