Skip to content

Commit

Permalink
video/smscufx: fix line counting in fb_write
Browse files Browse the repository at this point in the history
Line 0 and 1 were both written to line 0 (on the display) and all subsequent
lines had an offset of -1. The result was that the last line on the display
was never overwritten by writes to /dev/fbN.

The origin of this bug seems to have been udlfb.

Signed-off-by: Alexander Holler <holler@ahsoftware.de>
Cc: stable@vger.kernel.org
Signed-off-by: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
  • Loading branch information
Alexander Holler authored and Florian Tobias Schandinat committed Jul 24, 2012
1 parent 659f675 commit 2fe2d9f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/video/smscufx.c
Original file line number Diff line number Diff line change
Expand Up @@ -904,7 +904,7 @@ static ssize_t ufx_ops_write(struct fb_info *info, const char __user *buf,
result = fb_sys_write(info, buf, count, ppos);

if (result > 0) {
int start = max((int)(offset / info->fix.line_length) - 1, 0);
int start = max((int)(offset / info->fix.line_length), 0);
int lines = min((u32)((result / info->fix.line_length) + 1),
(u32)info->var.yres);

Expand Down

0 comments on commit 2fe2d9f

Please sign in to comment.