Skip to content

Commit

Permalink
Merge branch 'fix/asoc' into for-linus
Browse files Browse the repository at this point in the history
  • Loading branch information
Takashi Iwai committed Dec 2, 2010
2 parents c949e3d + af745bd commit 2ff38c9
Show file tree
Hide file tree
Showing 10 changed files with 22 additions and 18 deletions.
2 changes: 1 addition & 1 deletion sound/soc/codecs/wm8731.c
Original file line number Diff line number Diff line change
Expand Up @@ -526,7 +526,7 @@ static int wm8731_probe(struct snd_soc_codec *codec)
snd_soc_update_bits(codec, WM8731_RINVOL, 0x100, 0);

/* Disable bypass path by default */
snd_soc_update_bits(codec, WM8731_APANA, 0x4, 0);
snd_soc_update_bits(codec, WM8731_APANA, 0x8, 0);

snd_soc_add_controls(codec, wm8731_snd_controls,
ARRAY_SIZE(wm8731_snd_controls));
Expand Down
1 change: 1 addition & 0 deletions sound/soc/fsl/mpc8610_hpcd.c
Original file line number Diff line number Diff line change
Expand Up @@ -498,6 +498,7 @@ static int mpc8610_hpcd_probe(struct platform_device *pdev)
dev_err(&pdev->dev, "platform device add failed\n");
goto error;
}
dev_set_drvdata(&pdev->dev, sound_device);

of_node_put(codec_np);

Expand Down
1 change: 1 addition & 0 deletions sound/soc/fsl/p1022_ds.c
Original file line number Diff line number Diff line change
Expand Up @@ -498,6 +498,7 @@ static int p1022_ds_probe(struct platform_device *pdev)
dev_err(&pdev->dev, "platform device add failed\n");
goto error;
}
dev_set_drvdata(&pdev->dev, sound_device);

of_node_put(codec_np);

Expand Down
15 changes: 7 additions & 8 deletions sound/soc/nuc900/nuc900-ac97.c
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ static unsigned short nuc900_ac97_read(struct snd_ac97 *ac97,
mutex_lock(&ac97_mutex);

val = nuc900_checkready();
if (!!val) {
if (val) {
dev_err(nuc900_audio->dev, "AC97 codec is not ready\n");
goto out;
}
Expand Down Expand Up @@ -102,7 +102,7 @@ static void nuc900_ac97_write(struct snd_ac97 *ac97, unsigned short reg,
mutex_lock(&ac97_mutex);

tmp = nuc900_checkready();
if (!!tmp)
if (tmp)
dev_err(nuc900_audio->dev, "AC97 codec is not ready\n");

/* clear the R_WB bit and write register index */
Expand Down Expand Up @@ -149,7 +149,7 @@ static void nuc900_ac97_warm_reset(struct snd_ac97 *ac97)
udelay(100);

val = nuc900_checkready();
if (!!val)
if (val)
dev_err(nuc900_audio->dev, "AC97 codec is not ready\n");

mutex_unlock(&ac97_mutex);
Expand Down Expand Up @@ -263,8 +263,7 @@ static int nuc900_ac97_trigger(struct snd_pcm_substream *substream,
return ret;
}

static int nuc900_ac97_probe(struct platform_device *pdev,
struct snd_soc_dai *dai)
static int nuc900_ac97_probe(struct snd_soc_dai *dai)
{
struct nuc900_audio *nuc900_audio = nuc900_ac97_data;
unsigned long val;
Expand All @@ -284,12 +283,12 @@ static int nuc900_ac97_probe(struct platform_device *pdev,
return 0;
}

static void nuc900_ac97_remove(struct platform_device *pdev,
struct snd_soc_dai *dai)
static int nuc900_ac97_remove(struct snd_soc_dai *dai)
{
struct nuc900_audio *nuc900_audio = nuc900_ac97_data;

clk_disable(nuc900_audio->clk);
return 0;
}

static struct snd_soc_dai_ops nuc900_ac97_dai_ops = {
Expand All @@ -313,7 +312,7 @@ static struct snd_soc_dai_driver nuc900_ac97_dai = {
.channels_max = 2,
},
.ops = &nuc900_ac97_dai_ops,
}
};

static int __devinit nuc900_ac97_drvprobe(struct platform_device *pdev)
{
Expand Down
2 changes: 2 additions & 0 deletions sound/soc/nuc900/nuc900-audio.h
Original file line number Diff line number Diff line change
Expand Up @@ -110,4 +110,6 @@ struct nuc900_audio {

};

extern struct nuc900_audio *nuc900_ac97_data;

#endif /*end _NUC900_AUDIO_H */
11 changes: 6 additions & 5 deletions sound/soc/nuc900/nuc900-pcm.c
Original file line number Diff line number Diff line change
Expand Up @@ -50,12 +50,12 @@ static int nuc900_dma_hw_params(struct snd_pcm_substream *substream,
unsigned long flags;
int ret = 0;

spin_lock_irqsave(&nuc900_audio->lock, flags);

ret = snd_pcm_lib_malloc_pages(substream, params_buffer_bytes(params));
if (ret < 0)
return ret;

spin_lock_irqsave(&nuc900_audio->lock, flags);

nuc900_audio->substream = substream;
nuc900_audio->dma_addr[substream->stream] = runtime->dma_addr;
nuc900_audio->buffersize[substream->stream] =
Expand Down Expand Up @@ -169,6 +169,7 @@ static int nuc900_dma_prepare(struct snd_pcm_substream *substream)
struct snd_pcm_runtime *runtime = substream->runtime;
struct nuc900_audio *nuc900_audio = runtime->private_data;
unsigned long flags, val;
int ret = 0;

spin_lock_irqsave(&nuc900_audio->lock, flags);

Expand Down Expand Up @@ -197,10 +198,10 @@ static int nuc900_dma_prepare(struct snd_pcm_substream *substream)
AUDIO_WRITE(nuc900_audio->mmio + ACTL_RESET, val);
break;
default:
return -EINVAL;
ret = -EINVAL;
}
spin_unlock_irqrestore(&nuc900_audio->lock, flags);
return 0;
return ret;
}

static int nuc900_dma_trigger(struct snd_pcm_substream *substream, int cmd)
Expand Down Expand Up @@ -332,7 +333,7 @@ static struct snd_soc_platform_driver nuc900_soc_platform = {
.ops = &nuc900_dma_ops,
.pcm_new = nuc900_dma_new,
.pcm_free = nuc900_dma_free_dma_buffers,
}
};

static int __devinit nuc900_soc_platform_probe(struct platform_device *pdev)
{
Expand Down
2 changes: 1 addition & 1 deletion sound/soc/omap/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ config SND_OMAP_SOC_MCPDM
config SND_OMAP_SOC_N810
tristate "SoC Audio support for Nokia N810"
depends on SND_OMAP_SOC && MACH_NOKIA_N810 && I2C
depends on OMAP_MUX
select SND_OMAP_SOC_MCBSP
select OMAP_MUX
select SND_SOC_TLV320AIC3X
help
Say Y if you want to add support for SoC audio on Nokia N810.
Expand Down
2 changes: 1 addition & 1 deletion sound/soc/s6000/s6000-i2s.c
Original file line number Diff line number Diff line change
Expand Up @@ -434,7 +434,7 @@ static struct snd_soc_dai_driver s6000_i2s_dai = {
.rate_max = 1562500,
},
.ops = &s6000_i2s_dai_ops,
}
};

static int __devinit s6000_i2s_probe(struct platform_device *pdev)
{
Expand Down
2 changes: 1 addition & 1 deletion sound/soc/s6000/s6000-pcm.c
Original file line number Diff line number Diff line change
Expand Up @@ -473,7 +473,7 @@ static int s6000_pcm_new(struct snd_card *card,
}

res = request_irq(params->irq, s6000_pcm_irq, IRQF_SHARED,
s6000_soc_platform.name, pcm);
"s6000-audio", pcm);
if (res) {
printk(KERN_ERR "s6000-pcm couldn't get IRQ\n");
return res;
Expand Down
2 changes: 1 addition & 1 deletion sound/soc/s6000/s6105-ipcam.c
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ static int s6105_aic3x_init(struct snd_soc_pcm_runtime *rtd)

snd_soc_dapm_sync(codec);

snd_ctl_add(codec->snd_card, snd_ctl_new1(&audio_out_mux, codec));
snd_ctl_add(codec->card->snd_card, snd_ctl_new1(&audio_out_mux, codec));

return 0;
}
Expand Down

0 comments on commit 2ff38c9

Please sign in to comment.