Skip to content

Commit

Permalink
NVMe: Factor out queue_request_irq()
Browse files Browse the repository at this point in the history
Two callers with an almost identical long string of arguments, and
introducing a third soon.  Time to factor out the commonalities.

Signed-off-by: Matthew Wilcox <matthew.r.wilcox@intel.com>
  • Loading branch information
Matthew Wilcox committed Nov 4, 2011
1 parent b60503b commit 3001082
Showing 1 changed file with 9 additions and 4 deletions.
13 changes: 9 additions & 4 deletions drivers/block/nvme.c
Original file line number Diff line number Diff line change
Expand Up @@ -568,6 +568,13 @@ static struct nvme_queue *nvme_alloc_queue(struct nvme_dev *dev, int qid,
return NULL;
}

static int queue_request_irq(struct nvme_dev *dev, struct nvme_queue *nvmeq,
const char *name)
{
return request_irq(dev->entry[nvmeq->cq_vector].vector, nvme_irq,
IRQF_DISABLED | IRQF_SHARED, name, nvmeq);
}

static __devinit struct nvme_queue *nvme_create_queue(struct nvme_dev *dev,
int qid, int cq_size, int vector)
{
Expand All @@ -582,8 +589,7 @@ static __devinit struct nvme_queue *nvme_create_queue(struct nvme_dev *dev,
if (result < 0)
goto release_cq;

result = request_irq(dev->entry[vector].vector, nvme_irq,
IRQF_DISABLED | IRQF_SHARED, "nvme", nvmeq);
result = queue_request_irq(dev, nvmeq, "nvme");
if (result < 0)
goto release_sq;

Expand Down Expand Up @@ -630,8 +636,7 @@ static int __devinit nvme_configure_admin_queue(struct nvme_dev *dev)
return -EINTR;
}

result = request_irq(dev->entry[0].vector, nvme_irq,
IRQF_DISABLED | IRQF_SHARED, "nvme admin", nvmeq);
result = queue_request_irq(dev, nvmeq, "nvme admin");
dev->queues[0] = nvmeq;
return result;
}
Expand Down

0 comments on commit 3001082

Please sign in to comment.