Skip to content

Commit

Permalink
x86: put timer_rand_state pointer into irq_desc
Browse files Browse the repository at this point in the history
irq_timer_state[] is a NR_IRQS sized array that is a side-by array to
the real irq_desc[] array.

Integrate that field into the (now dynamic) irq_desc dynamic array and
save some RAM.

v2: keep the old way to support arch not support irq_desc

Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
  • Loading branch information
Yinghai Lu authored and Ingo Molnar committed Oct 16, 2008
1 parent e5a5371 commit 3060d6f
Show file tree
Hide file tree
Showing 2 changed files with 63 additions and 5 deletions.
66 changes: 61 additions & 5 deletions drivers/char/random.c
Original file line number Diff line number Diff line change
Expand Up @@ -558,7 +558,7 @@ struct timer_rand_state {
unsigned dont_count_entropy:1;
};

static struct timer_rand_state input_timer_state;
#ifndef CONFIG_HAVE_SPARSE_IRQ

#ifdef CONFIG_HAVE_DYN_ARRAY
static struct timer_rand_state **irq_timer_state;
Expand All @@ -567,6 +567,51 @@ DEFINE_DYN_ARRAY(irq_timer_state, sizeof(struct timer_rand_state *), nr_irqs, PA
static struct timer_rand_state *irq_timer_state[NR_IRQS];
#endif

static struct timer_rand_state *get_timer_rand_state(unsigned int irq)
{
if (irq >= nr_irqs)
return NULL;

return irq_timer_state[irq];
}

static void set_timer_rand_state(unsigned int irq, struct timer_rand_state *state)
{
if (irq >= nr_irqs)
return;

irq_timer_state[irq] = state;
}

#else

static struct timer_rand_state *get_timer_rand_state(unsigned int irq)
{
struct irq_desc *desc;

desc = irq_to_desc(irq);

if (!desc)
return NULL;

return desc->timer_rand_state;
}

static void set_timer_rand_state(unsigned int irq, struct timer_rand_state *state)
{
struct irq_desc *desc;

desc = irq_to_desc(irq);

if (!desc)
return;

desc->timer_rand_state = state;
}
#endif

static struct timer_rand_state input_timer_state;

/*
* This function adds entropy to the entropy "pool" by using timing
* delays. It uses the timer_rand_state structure to make an estimate
Expand Down Expand Up @@ -654,11 +699,15 @@ EXPORT_SYMBOL_GPL(add_input_randomness);

void add_interrupt_randomness(int irq)
{
if (irq >= nr_irqs || irq_timer_state[irq] == NULL)
struct timer_rand_state *state;

state = get_timer_rand_state(irq);

if (state == NULL)
return;

DEBUG_ENT("irq event %d\n", irq);
add_timer_randomness(irq_timer_state[irq], 0x100 + irq);
add_timer_randomness(state, 0x100 + irq);
}

#ifdef CONFIG_BLOCK
Expand Down Expand Up @@ -918,7 +967,14 @@ void rand_initialize_irq(int irq)
{
struct timer_rand_state *state;

if (irq >= nr_irqs || irq_timer_state[irq])
#ifndef CONFIG_HAVE_SPARSE_IRQ
if (irq >= nr_irqs)
return;
#endif

state = get_timer_rand_state(irq);

if (state)
return;

/*
Expand All @@ -927,7 +983,7 @@ void rand_initialize_irq(int irq)
*/
state = kzalloc(sizeof(struct timer_rand_state), GFP_KERNEL);
if (state)
irq_timer_state[irq] = state;
set_timer_rand_state(irq, state);
}

#ifdef CONFIG_BLOCK
Expand Down
2 changes: 2 additions & 0 deletions include/linux/irq.h
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,7 @@ struct irq_chip {
const char *typename;
};

struct timer_rand_state;
/**
* struct irq_desc - interrupt descriptor
*
Expand Down Expand Up @@ -155,6 +156,7 @@ struct irq_desc {
unsigned int irq;
#ifdef CONFIG_HAVE_SPARSE_IRQ
struct irq_desc *next;
struct timer_rand_state *timer_rand_state;
#endif
irq_flow_handler_t handle_irq;
struct irq_chip *chip;
Expand Down

0 comments on commit 3060d6f

Please sign in to comment.