Skip to content

Commit

Permalink
staging: comedi: addi_apci_1516: remove setting of s->len_chanlist
Browse files Browse the repository at this point in the history
This value only has meaning for subdevices that support async commands.
Since this driver does not support async commands on any of its subdevices,
don't bother setting it . The comedi core will detect this and set the
value appropriately.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
H Hartley Sweeten authored and Greg Kroah-Hartman committed Nov 13, 2012
1 parent 87450c0 commit 308d703
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions drivers/staging/comedi/drivers/addi_apci_1516.c
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,6 @@ static int __devinit apci1516_auto_attach(struct comedi_device *dev,
s->subdev_flags = SDF_READABLE | SDF_GROUND | SDF_COMMON;
s->n_chan = this_board->di_nchan;
s->maxdata = 1;
s->len_chanlist = this_board->di_nchan;
s->range_table = &range_digital;
s->io_bits = 0; /* all bits input */
s->insn_bits = apci1516_di_insn_bits;
Expand All @@ -256,7 +255,6 @@ static int __devinit apci1516_auto_attach(struct comedi_device *dev,
SDF_READABLE | SDF_WRITEABLE | SDF_GROUND | SDF_COMMON;
s->n_chan = this_board->do_nchan;
s->maxdata = 1;
s->len_chanlist = this_board->do_nchan;
s->range_table = &range_digital;
s->io_bits = 0xf; /* all bits output */
s->insn_bits = apci1516_do_insn_bits;
Expand All @@ -271,7 +269,6 @@ static int __devinit apci1516_auto_attach(struct comedi_device *dev,
s->subdev_flags = SDF_WRITEABLE | SDF_GROUND | SDF_COMMON;
s->n_chan = 1;
s->maxdata = 0;
s->len_chanlist = 1;
s->range_table = &range_digital;
s->insn_write = i_APCI1516_StartStopWriteWatchdog;
s->insn_read = i_APCI1516_ReadWatchdog;
Expand Down

0 comments on commit 308d703

Please sign in to comment.