Skip to content

Commit

Permalink
[PATCH] Char: mxser_new, remove useless spinlock
Browse files Browse the repository at this point in the history
gm_lock is useless, since ISA is configured at init time and there it's
serialized.

Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Jiri Slaby authored and Linus Torvalds committed Feb 11, 2007
1 parent c76b093 commit 30a063a
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions drivers/char/mxser_new.c
Original file line number Diff line number Diff line change
Expand Up @@ -313,7 +313,6 @@ static int mxvar_diagflag;
static unsigned char mxser_msr[MXSER_PORTS + 1];
static struct mxser_mon_ext mon_data_ext;
static int mxser_set_baud_method[MXSER_PORTS + 1];
static spinlock_t gm_lock;

#ifdef CONFIG_PCI
static int __devinit CheckIsMoxaMust(int io)
Expand Down Expand Up @@ -1377,15 +1376,13 @@ static int __init mxser_program_mode(int port)
{
int id, i, j, n;

spin_lock(&gm_lock);
outb(0, port);
outb(0, port);
outb(0, port);
(void)inb(port);
(void)inb(port);
outb(0, port);
(void)inb(port);
spin_unlock(&gm_lock);

id = inb(port + 1) & 0x1F;
if ((id != C168_ASIC_ID) &&
Expand Down Expand Up @@ -2684,7 +2681,6 @@ static int __init mxser_module_init(void)
mxvar_sdriver = alloc_tty_driver(MXSER_PORTS + 1);
if (!mxvar_sdriver)
return -ENOMEM;
spin_lock_init(&gm_lock);

printk(KERN_INFO "MOXA Smartio/Industio family driver version %s\n",
MXSER_VERSION);
Expand Down

0 comments on commit 30a063a

Please sign in to comment.