Skip to content

Commit

Permalink
Staging: DST: Do not allow empty barriers.
Browse files Browse the repository at this point in the history
Do not allow empty barriers or generic_make_request() ->  scsi_setup_fs_cmnd()
will explode

Signed-off-by: Evgeniy Polyakov <zbr@ioremap.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Evgeniy Polyakov authored and Greg Kroah-Hartman committed Apr 3, 2009
1 parent e55b689 commit 30c7c1c
Showing 1 changed file with 23 additions and 0 deletions.
23 changes: 23 additions & 0 deletions drivers/staging/dst/dcore.c
Original file line number Diff line number Diff line change
Expand Up @@ -100,10 +100,33 @@ static void dst_node_set_size(struct dst_node *n)
static int dst_request(struct request_queue *q, struct bio *bio)
{
struct dst_node *n = q->queuedata;
int err = -EIO;

if (bio_empty_barrier(bio) && !q->prepare_discard_fn) {
/*
* This is a dirty^Wnice hack, but if we complete this
* operation with -EOPNOTSUPP like intended, XFS
* will stuck and freeze the machine. This may be
* not particulary XFS problem though, but it is the
* only FS which sends empty barrier at umount time
* I worked with.
*
* Empty barriers are not allowed anyway, see 51fd77bd9f512
* for example, although later it was changed to bio_discard()
* only, which does not work in this case.
*/
//err = -EOPNOTSUPP;
err = 0;
goto end_io;
}

bio_get(bio);

return dst_process_bio(n, bio);

end_io:
bio_endio(bio, err);
return err;
}

/*
Expand Down

0 comments on commit 30c7c1c

Please sign in to comment.