Skip to content

Commit

Permalink
perf_counter tools: Handle kernels with !CONFIG_PERF_COUNTER
Browse files Browse the repository at this point in the history
If perf is run on a !CONFIG_PERF_COUNTER kernel right now it
bails out with no messages or with confusing messages.

Standardize this case some more and explain the situation.

Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
LKML-Reference: <new-submission>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
  • Loading branch information
Ingo Molnar committed Jun 7, 2009
1 parent 3da297a commit 30c806a
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 7 deletions.
7 changes: 4 additions & 3 deletions tools/perf/builtin-record.c
Original file line number Diff line number Diff line change
Expand Up @@ -356,9 +356,6 @@ static void create_counter(int counter, int cpu, pid_t pid)
if (fd[nr_cpu][counter] < 0) {
int err = errno;

if (verbose)
error("sys_perf_counter_open() syscall returned with %d (%s)\n",
fd[nr_cpu][counter], strerror(err));
if (err == EPERM)
die("Permission error - are you root?\n");

Expand All @@ -376,6 +373,10 @@ static void create_counter(int counter, int cpu, pid_t pid)
attr->config = PERF_COUNT_CPU_CLOCK;
goto try_again;
}
printf("\n");
error("perfcounter syscall returned with %d (%s)\n",
fd[nr_cpu][counter], strerror(err));
die("No CONFIG_PERF_COUNTERS=y kernel support configured?\n");
exit(-1);
}

Expand Down
8 changes: 4 additions & 4 deletions tools/perf/builtin-top.c
Original file line number Diff line number Diff line change
Expand Up @@ -551,10 +551,6 @@ static void start_counter(int i, int counter)
if (fd[i][counter] < 0) {
int err = errno;

if (verbose)
error("sys_perf_counter_open() syscall returned with %d (%s)\n",
fd[i][counter], strerror(err));

if (err == EPERM)
die("No permission - are you root?\n");
/*
Expand All @@ -572,6 +568,10 @@ static void start_counter(int i, int counter)
attr->config = PERF_COUNT_CPU_CLOCK;
goto try_again;
}
printf("\n");
error("perfcounter syscall returned with %d (%s)\n",
fd[i][counter], strerror(err));
die("No CONFIG_PERF_COUNTERS=y kernel support configured?\n");
exit(-1);
}
assert(fd[i][counter] >= 0);
Expand Down

0 comments on commit 30c806a

Please sign in to comment.