Skip to content

Commit

Permalink
powerpc/BSR: fix device_create() return value check
Browse files Browse the repository at this point in the history
Use IS_ERR() instead of comparing to NULL.

Signed-off-by: Jani Nikula <ext-jani.1.nikula@nokia.com>
Acked-by: Sonny Rao <sonnyrao@us.ibm.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
  • Loading branch information
Jani Nikula authored and Jiri Kosina committed Mar 15, 2010
1 parent 3e21ec2 commit 30c96ce
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/char/bsr.c
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,7 @@ static int bsr_add_node(struct device_node *bn)

cur->bsr_device = device_create(bsr_class, NULL, cur->bsr_dev,
cur, cur->bsr_name);
if (!cur->bsr_device) {
if (IS_ERR(cur->bsr_device)) {
printk(KERN_ERR "device_create failed for %s\n",
cur->bsr_name);
cdev_del(&cur->bsr_cdev);
Expand Down

0 comments on commit 30c96ce

Please sign in to comment.