Skip to content

Commit

Permalink
[PATCH] uml: build cleanups
Browse files Browse the repository at this point in the history
Added missing include list to uml AFLAGS

Killed magic for stubs.  [So] - it was needed only because of messed AFLAGS
Switched segv_stubs.c to kernel CFLAGS sans profile, instead of user ones
Killed STUBS_CFLAGS - it's not needed and the only remaining use had been
gratitious - it only polluted CFLAGS

Signed-off-by: Al Viro <viro@parcelfarce.linux.theplanet.co.uk>
Signed-off-by: Jeff Dike <jdike@addtoit.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
Al Viro authored and Linus Torvalds committed Sep 5, 2005
1 parent e32dacb commit 30f7dab
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 14 deletions.
2 changes: 1 addition & 1 deletion arch/um/Makefile-x86_64
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ START := 0x60000000

#We #undef __x86_64__ for kernelspace, not for userspace where
#it's needed for headers to work!
CFLAGS += -U__$(SUBARCH)__ -fno-builtin $(STUB_CFLAGS)
CFLAGS += -U__$(SUBARCH)__ -fno-builtin
USER_CFLAGS += -fno-builtin

ELF_ARCH := i386:x86-64
Expand Down
6 changes: 1 addition & 5 deletions arch/um/sys-i386/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,7 @@ semaphore.c-dir = kernel
highmem.c-dir = mm
module.c-dir = kernel

STUB_CFLAGS = -Wp,-MD,$(depfile) $(call unprofile,$(USER_CFLAGS))

# _cflags works with kernel files, not with userspace ones, but c_flags does,
# why ask why?
$(obj)/stub_segv.o : c_flags = $(STUB_CFLAGS)
$(obj)/stub_segv.o : _c_flags = $(call unprofile,$(CFLAGS))

subdir- := util

Expand Down
3 changes: 1 addition & 2 deletions arch/um/sys-i386/stub_segv.c
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,7 @@
* Licensed under the GPL
*/

#include <signal.h>
#include <asm/sigcontext.h>
#include <asm/signal.h>
#include <asm/unistd.h>
#include "uml-config.h"
#include "sysdep/sigcontext.h"
Expand Down
6 changes: 1 addition & 5 deletions arch/um/sys-x86_64/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,7 @@ memcpy.S-dir = lib
thunk.S-dir = lib
module.c-dir = kernel

STUB_CFLAGS = -Wp,-MD,$(depfile) $(call unprofile,$(USER_CFLAGS))

# _cflags works with kernel files, not with userspace ones, but c_flags does,
# why ask why?
$(obj)/stub_segv.o : c_flags = $(STUB_CFLAGS)
$(obj)/stub_segv.o: _c_flags = $(call unprofile,$(CFLAGS))

subdir- := util

Expand Down
3 changes: 2 additions & 1 deletion arch/um/sys-x86_64/stub_segv.c
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,10 @@
* Licensed under the GPL
*/

#include <signal.h>
#include <asm/signal.h>
#include <linux/compiler.h>
#include <asm/unistd.h>
#include <asm/ucontext.h>
#include "uml-config.h"
#include "sysdep/sigcontext.h"
#include "sysdep/faultinfo.h"
Expand Down

0 comments on commit 30f7dab

Please sign in to comment.