Skip to content

Commit

Permalink
[PATCH] i386: avoid gcc extension
Browse files Browse the repository at this point in the history
setcc() in math-emu is written as a gcc extension statement expression
macro that returns a value.  However, it's not used that way and it's not
needed like that, so just make it a inline function so that we
don't use an extension when it's not needed.

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Signed-off-by: Andi Kleen <ak@suse.de>
Cc: Andi Kleen <ak@suse.de>
Cc: Christoph Hellwig <hch@infradead.org>
Cc: Segher Boessenkool <segher@kernel.crashing.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
  • Loading branch information
Randy Dunlap authored and Andi Kleen committed Feb 13, 2007
1 parent 30b82ea commit 3101673
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions arch/i386/math-emu/status_w.h
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,11 @@

#define status_word() \
((partial_status & ~SW_Top & 0xffff) | ((top << SW_Top_Shift) & SW_Top))
#define setcc(cc) ({ \
partial_status &= ~(SW_C0|SW_C1|SW_C2|SW_C3); \
partial_status |= (cc) & (SW_C0|SW_C1|SW_C2|SW_C3); })
static inline void setcc(int cc)
{
partial_status &= ~(SW_C0|SW_C1|SW_C2|SW_C3);
partial_status |= (cc) & (SW_C0|SW_C1|SW_C2|SW_C3);
}

#ifdef PECULIAR_486
/* Default, this conveys no information, but an 80486 does it. */
Expand Down

0 comments on commit 3101673

Please sign in to comment.