Skip to content

Commit

Permalink
V4L/DVB (10505): tda8290: Print an error if i2c_gate is not provided
Browse files Browse the repository at this point in the history
While here, be sure that gate will be kept disabled if an error occurs.

Cc: Michael Krufky <mkrufky@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
  • Loading branch information
Mauro Carvalho Chehab committed Mar 30, 2009
1 parent 68d5ce7 commit 3106381
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion drivers/media/common/tuners/tda8290.c
Original file line number Diff line number Diff line change
Expand Up @@ -566,8 +566,11 @@ static int tda829x_find_tuner(struct dvb_frontend *fe)
u8 data;
struct i2c_msg msg = { .flags = I2C_M_RD, .buf = &data, .len = 1 };

if (NULL == analog_ops->i2c_gate_ctrl)
if (!analog_ops->i2c_gate_ctrl) {
printk(KERN_ERR "tda8290: no gate control were provided!\n");

return -EINVAL;
}

analog_ops->i2c_gate_ctrl(fe, 1);

Expand Down Expand Up @@ -615,6 +618,7 @@ static int tda829x_find_tuner(struct dvb_frontend *fe)

if (ret != 1) {
tuner_warn("tuner access failed!\n");
analog_ops->i2c_gate_ctrl(fe, 0);
return -EREMOTEIO;
}

Expand Down

0 comments on commit 3106381

Please sign in to comment.