Skip to content

Commit

Permalink
[NETNS]: fix net released by rcu callback
Browse files Browse the repository at this point in the history
When a network namespace reference is held by a network subsystem,
and when this reference is decremented in a rcu update callback, we
must ensure that there is no more outstanding rcu update before
trying to free the network namespace.

In the normal case, the rcu_barrier is called when the network namespace
is exiting in the cleanup_net function.

But when a network namespace creation fails, and the subsystems are
undone (like the cleanup), the rcu_barrier is missing.

This patch adds the missing rcu_barrier.

Signed-off-by: Daniel Lezcano <dlezcano@fr.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Daniel Lezcano authored and David S. Miller committed Oct 31, 2007
1 parent 93ee31f commit 310928d
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions net/core/net_namespace.c
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,8 @@ static int setup_net(struct net *net)
if (ops->exit)
ops->exit(net);
}

rcu_barrier();
goto out;
}

Expand Down

0 comments on commit 310928d

Please sign in to comment.