Skip to content

Commit

Permalink
staging:wlan-ng: cleanup p80211skb_free and p80211skb_rxmeta_detach
Browse files Browse the repository at this point in the history
these functions doesn't need return at the end of the function

Signed-off-by: Devendra Naga <devendra.aaru@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Devendra Naga authored and Greg Kroah-Hartman committed Sep 10, 2012
1 parent 7694538 commit 311e24f
Showing 1 changed file with 3 additions and 6 deletions.
9 changes: 3 additions & 6 deletions drivers/staging/wlan-ng/p80211conv.c
Original file line number Diff line number Diff line change
Expand Up @@ -559,26 +559,24 @@ void p80211skb_rxmeta_detach(struct sk_buff *skb)
/* Sanity checks */
if (skb == NULL) { /* bad skb */
pr_debug("Called w/ null skb.\n");
goto exit;
return;
}
frmmeta = P80211SKB_FRMMETA(skb);
if (frmmeta == NULL) { /* no magic */
pr_debug("Called w/ bad frmmeta magic.\n");
goto exit;
return;
}
rxmeta = frmmeta->rx;
if (rxmeta == NULL) { /* bad meta ptr */
pr_debug("Called w/ bad rxmeta ptr.\n");
goto exit;
return;
}

/* Free rxmeta */
kfree(rxmeta);

/* Clear skb->cb */
memset(skb->cb, 0, sizeof(skb->cb));
exit:
return;
}

/*----------------------------------------------------------------
Expand Down Expand Up @@ -660,5 +658,4 @@ void p80211skb_free(struct wlandevice *wlandev, struct sk_buff *skb)
else
printk(KERN_ERR "Freeing an skb (%p) w/ no frmmeta.\n", skb);
dev_kfree_skb(skb);
return;
}

0 comments on commit 311e24f

Please sign in to comment.