Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 182345
b: refs/heads/master
c: de17648
h: refs/heads/master
i:
  182343: ba8eaf9
v: v3
  • Loading branch information
Arnaldo Carvalho de Melo authored and Ingo Molnar committed Jan 13, 2010
1 parent 36566da commit 3128e41
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 20 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: f92cb24c78a7c853435e46a20d1bd5c894378132
refs/heads/master: de1764892a61a3ed212973cc028c80dd083179dd
4 changes: 1 addition & 3 deletions trunk/tools/perf/builtin-probe.c
Original file line number Diff line number Diff line change
Expand Up @@ -235,9 +235,7 @@ int cmd_probe(int argc, const char **argv, const char *prefix __used)
session.psession = perf_session__new(NULL, O_WRONLY, false);
if (session.psession == NULL)
die("Failed to init perf_session.");
session.kmap = map_groups__find_by_name(&session.psession->kmaps,
MAP__FUNCTION,
"[kernel.kallsyms]");
session.kmap = session.psession->vmlinux_maps[MAP__FUNCTION];
if (!session.kmap)
die("Could not find kernel map.\n");

Expand Down
1 change: 1 addition & 0 deletions trunk/tools/perf/util/session.h
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ struct perf_session {
struct map_groups kmaps;
struct rb_root threads;
struct thread *last_match;
struct map *vmlinux_maps[MAP__NR_TYPES];
struct events_stats events_stats;
unsigned long event_total[PERF_RECORD_MAX];
unsigned long unknown_events;
Expand Down
29 changes: 13 additions & 16 deletions trunk/tools/perf/util/symbol.c
Original file line number Diff line number Diff line change
Expand Up @@ -1662,7 +1662,7 @@ size_t dsos__fprintf_buildid(FILE *fp)
__dsos__fprintf_buildid(&dsos__user, fp));
}

static struct dso *dsos__create_kernel( const char *vmlinux)
static struct dso *dsos__create_kernel(const char *vmlinux)
{
struct dso *kernel = dso__new(vmlinux ?: "[kernel.kallsyms]");

Expand Down Expand Up @@ -1691,29 +1691,26 @@ static struct dso *dsos__create_kernel( const char *vmlinux)
return NULL;
}

static int map_groups__create_kernel_maps(struct map_groups *self, const char *vmlinux)
static int map_groups__create_kernel_maps(struct map_groups *self,
struct map *vmlinux_maps[MAP__NR_TYPES],
const char *vmlinux)
{
struct map *functions, *variables;
struct dso *kernel = dsos__create_kernel(vmlinux);
enum map_type type;

if (kernel == NULL)
return -1;

functions = map__new2(0, kernel, MAP__FUNCTION);
if (functions == NULL)
return -1;
for (type = 0; type < MAP__NR_TYPES; ++type) {
vmlinux_maps[type] = map__new2(0, kernel, type);
if (vmlinux_maps[type] == NULL)
return -1;

variables = map__new2(0, kernel, MAP__VARIABLE);
if (variables == NULL) {
map__delete(functions);
return -1;
vmlinux_maps[type]->map_ip =
vmlinux_maps[type]->unmap_ip = identity__map_ip;
map_groups__insert(self, vmlinux_maps[type]);
}

functions->map_ip = functions->unmap_ip =
variables->map_ip = variables->unmap_ip = identity__map_ip;
map_groups__insert(self, functions);
map_groups__insert(self, variables);

return 0;
}

Expand Down Expand Up @@ -1824,7 +1821,7 @@ int symbol__init(void)

int perf_session__create_kernel_maps(struct perf_session *self)
{
if (map_groups__create_kernel_maps(&self->kmaps,
if (map_groups__create_kernel_maps(&self->kmaps, self->vmlinux_maps,
symbol_conf.vmlinux_name) < 0)
return -1;

Expand Down

0 comments on commit 3128e41

Please sign in to comment.