Skip to content

Commit

Permalink
SELinux: fix memory leakage in /security/selinux/hooks.c
Browse files Browse the repository at this point in the history
Fix memory leakage in /security/selinux/hooks.c

The buffer always needs to be freed here; we either error
out or allocate more memory.

Reported-by: iceberg <strakh@ispras.ru>
Signed-off-by: James Morris <jmorris@namei.org>
Acked-by:  Stephen Smalley <sds@tycho.nsa.gov>
  • Loading branch information
James Morris committed Aug 10, 2009
1 parent 85dfd81 commit 314dabb
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion security/selinux/hooks.c
Original file line number Diff line number Diff line change
Expand Up @@ -1285,14 +1285,15 @@ static int inode_doinit_with_dentry(struct inode *inode, struct dentry *opt_dent
rc = inode->i_op->getxattr(dentry, XATTR_NAME_SELINUX,
context, len);
if (rc == -ERANGE) {
kfree(context);

/* Need a larger buffer. Query for the right size. */
rc = inode->i_op->getxattr(dentry, XATTR_NAME_SELINUX,
NULL, 0);
if (rc < 0) {
dput(dentry);
goto out_unlock;
}
kfree(context);
len = rc;
context = kmalloc(len+1, GFP_NOFS);
if (!context) {
Expand Down

0 comments on commit 314dabb

Please sign in to comment.