Skip to content

Commit

Permalink
RDMA/cxgb4: Use simple_read_from_buffer() for debugfs handlers
Browse files Browse the repository at this point in the history
We can replace our equivalent open-coded version.

Signed-off-by: Steve Wise <swise@opengridcomputing.com>
Signed-off-by: Roland Dreier <rolandd@cisco.com>
  • Loading branch information
Steve Wise authored and Roland Dreier committed Oct 12, 2010
1 parent 8bbac89 commit 3160977
Showing 1 changed file with 1 addition and 25 deletions.
26 changes: 1 addition & 25 deletions drivers/infiniband/hw/cxgb4/device.c
Original file line number Diff line number Diff line change
Expand Up @@ -68,32 +68,8 @@ static ssize_t debugfs_read(struct file *file, char __user *buf, size_t count,
loff_t *ppos)
{
struct c4iw_debugfs_data *d = file->private_data;
loff_t pos = *ppos;
loff_t avail = d->pos;

if (pos < 0)
return -EINVAL;
if (pos >= avail)
return 0;
if (count > avail - pos)
count = avail - pos;

while (count) {
size_t len = 0;

len = min((int)count, (int)d->pos - (int)pos);
if (copy_to_user(buf, d->buf + pos, len))
return -EFAULT;
if (len == 0)
return -EINVAL;

buf += len;
pos += len;
count -= len;
}
count = pos - *ppos;
*ppos = pos;
return count;
return simple_read_from_buffer(buf, count, ppos, d->buf, d->pos);
}

static int dump_qp(int id, void *p, void *data)
Expand Down

0 comments on commit 3160977

Please sign in to comment.