Skip to content

Commit

Permalink
target: pack struct se_task more tightly
Browse files Browse the repository at this point in the history
Rearrange the fields in se_task to avoid holes.  Also increase the
flags field to 16 bits as we have the space for it, and this makes
adding new flags safer.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
  • Loading branch information
Christoph Hellwig authored and Nicholas Bellinger committed Oct 24, 2011
1 parent 04629b7 commit 3189b06
Showing 1 changed file with 15 additions and 15 deletions.
30 changes: 15 additions & 15 deletions include/target/target_core_base.h
Original file line number Diff line number Diff line change
Expand Up @@ -402,24 +402,24 @@ struct se_queue_obj {
} ____cacheline_aligned;

struct se_task {
unsigned char task_sense;
struct scatterlist *task_sg;
u32 task_sg_nents;
struct scatterlist *task_sg_bidi;
u8 task_scsi_status;
u8 task_flags;
int task_error_status;
unsigned long long task_lba;
u32 task_sectors;
u32 task_size;
u32 task_sectors;
u32 task_size;
struct se_cmd *task_se_cmd;
struct scatterlist *task_sg;
struct scatterlist *task_sg_bidi;
u32 task_sg_nents;
u16 task_flags;
u8 task_sense;
u8 task_scsi_status;
int task_error_status;
enum dma_data_direction task_data_direction;
struct se_cmd *task_se_cmd;
struct completion task_stop_comp;
atomic_t task_state_active;
atomic_t task_state_active;
struct timer_list task_timer;
struct list_head t_list;
struct list_head t_execute_list;
struct list_head t_state_list;
struct list_head t_list;
struct list_head t_execute_list;
struct list_head t_state_list;
struct completion task_stop_comp;
} ____cacheline_aligned;

struct se_cmd {
Expand Down

0 comments on commit 3189b06

Please sign in to comment.