Skip to content

Commit

Permalink
ASoC: wm8904: Remove unnecessary call to snd_soc_dapm_new_widgets()
Browse files Browse the repository at this point in the history
The core will call snd_soc_dapm_new_widgets() once all components of the card
have been initialized, so there is no need to do this manually in the driver.
Calling it earlier also might result in a partially instantiated system being
powered up which cause undesired side effects.

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Mark Brown <broonie@linaro.org>
  • Loading branch information
Lars-Peter Clausen authored and Mark Brown committed Aug 27, 2013
1 parent e94a093 commit 318ee16
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion sound/soc/codecs/wm8904.c
Original file line number Diff line number Diff line change
Expand Up @@ -1202,7 +1202,6 @@ static int wm8904_add_widgets(struct snd_soc_codec *codec)
break;
}

snd_soc_dapm_new_widgets(dapm);
return 0;
}

Expand Down

0 comments on commit 318ee16

Please sign in to comment.