Skip to content

Commit

Permalink
drm/i915: invalidate render cache on gen2
Browse files Browse the repository at this point in the history
It looks like we also need to flush the render cache when we just
invalidate it. This fixes a regression in i-g-t/gem_tiled_blits on my
i855gm. I guess the render cache there is virtually indexed, so we
need to clean it when changing gtt mappings.

This regression has been introduce in

commit 46f0f8d
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date:   Wed Apr 18 11:12:11 2012 +0100

    drm/i915: Don't set a MBZ bit in gen2/3 MI_FLUSH

Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-Off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
  • Loading branch information
Daniel Vetter committed Apr 20, 2012
1 parent 284d5df commit 31b14c9
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/gpu/drm/i915/intel_ringbuffer.c
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ gen2_render_ring_flush(struct intel_ring_buffer *ring,
int ret;

cmd = MI_FLUSH;
if ((flush_domains & I915_GEM_DOMAIN_RENDER) == 0)
if (((invalidate_domains|flush_domains) & I915_GEM_DOMAIN_RENDER) == 0)
cmd |= MI_NO_WRITE_FLUSH;

if (invalidate_domains & I915_GEM_DOMAIN_SAMPLER)
Expand Down

0 comments on commit 31b14c9

Please sign in to comment.