Skip to content

Commit

Permalink
drivers/cdrom/gdrom.c: fix device number leak
Browse files Browse the repository at this point in the history
Without this patch, gdrom_major will leak when gd.cd_info alloc fails.

Signed-off-by: Libo Chen <libo.chen@huawei.com>
Cc: Jens Axboe <axboe@kernel.dk>
Acked-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Libo Chen authored and Linus Torvalds committed Jul 3, 2013
1 parent 4a184b4 commit 31bd8fb
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/cdrom/gdrom.c
Original file line number Diff line number Diff line change
Expand Up @@ -830,9 +830,9 @@ static int probe_gdrom(struct platform_device *devptr)
del_gendisk(gd.disk);
probe_fail_no_disk:
kfree(gd.cd_info);
probe_fail_no_mem:
unregister_blkdev(gdrom_major, GDROM_DEV_NAME);
gdrom_major = 0;
probe_fail_no_mem:
pr_warning("Probe failed - error is 0x%X\n", err);
return err;
}
Expand Down

0 comments on commit 31bd8fb

Please sign in to comment.