Skip to content

Commit

Permalink
leds: leds-ns2: use gpio_request_one
Browse files Browse the repository at this point in the history
Using gpio_request_one can make the code simpler because it can
set the direction and initial value in one shot.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Signed-off-by: Bryan Wu <cooloney@gmail.com>
  • Loading branch information
Jingoo Han authored and Bryan Wu committed Nov 26, 2012
1 parent 507d967 commit 31c3dc7
Showing 1 changed file with 7 additions and 14 deletions.
21 changes: 7 additions & 14 deletions drivers/leds/leds-ns2.c
Original file line number Diff line number Diff line change
Expand Up @@ -191,25 +191,18 @@ create_ns2_led(struct platform_device *pdev, struct ns2_led_data *led_dat,
int ret;
enum ns2_led_modes mode;

ret = gpio_request(template->cmd, template->name);
if (ret == 0) {
ret = gpio_direction_output(template->cmd,
gpio_get_value(template->cmd));
if (ret)
gpio_free(template->cmd);
}
ret = gpio_request_one(template->cmd,
GPIOF_DIR_OUT | gpio_get_value(template->cmd),
template->name);
if (ret) {
dev_err(&pdev->dev, "%s: failed to setup command GPIO\n",
template->name);
return ret;
}

ret = gpio_request(template->slow, template->name);
if (ret == 0) {
ret = gpio_direction_output(template->slow,
gpio_get_value(template->slow));
if (ret)
gpio_free(template->slow);
}
ret = gpio_request_one(template->slow,
GPIOF_DIR_OUT | gpio_get_value(template->slow),
template->name);
if (ret) {
dev_err(&pdev->dev, "%s: failed to setup slow GPIO\n",
template->name);
Expand Down

0 comments on commit 31c3dc7

Please sign in to comment.