Skip to content

Commit

Permalink
i386/x8664: cleanup the shared hpet code
Browse files Browse the repository at this point in the history
Remove hpet_readl/writel from vsyscall.h, where it does not belong
anyway. Use the hpet code itself.

Signed-off-by: Chris Wright <chrisw@sous-sol.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Arjan van de Ven <arjan@linux.intel.com>
  • Loading branch information
Chris Wright authored and Thomas Gleixner committed Oct 12, 2007
1 parent 39d0b7b commit 31c435d
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 8 deletions.
6 changes: 1 addition & 5 deletions arch/x86/kernel/hpet.c
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,7 @@
unsigned long hpet_address;
static void __iomem *hpet_virt_address;

/* Temporary hack. Cleanup after x86_64 clock events conversion */
#undef hpet_readl
#undef hpet_writel

static inline unsigned long hpet_readl(unsigned long a)
unsigned long hpet_readl(unsigned long a)
{
return readl(hpet_virt_address + a);
}
Expand Down
2 changes: 2 additions & 0 deletions include/asm-x86/hpet.h
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@
extern unsigned long hpet_address;
extern int is_hpet_enabled(void);
extern int hpet_enable(void);
extern unsigned long hpet_readl(unsigned long a);

#ifdef CONFIG_HPET_EMULATE_RTC

Expand All @@ -84,6 +85,7 @@ extern irqreturn_t hpet_rtc_interrupt(int irq, void *dev_id);
#else

static inline int hpet_enable(void) { return 0; }
static inline unsigned long hpet_readl(unsigned long a) { return 0; }

#endif /* CONFIG_HPET_TIMER */
#endif /* ASM_X86_HPET_H */
3 changes: 0 additions & 3 deletions include/asm-x86/vsyscall.h
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,6 @@ enum vsyscall_num {
#define VGETCPU_RDTSCP 1
#define VGETCPU_LSL 2

#define hpet_readl(a) readl((const void __iomem *)fix_to_virt(FIX_HPET_BASE) + a)
#define hpet_writel(d,a) writel(d, (void __iomem *)fix_to_virt(FIX_HPET_BASE) + a)

extern int __vgetcpu_mode;
extern volatile unsigned long __jiffies;

Expand Down

0 comments on commit 31c435d

Please sign in to comment.