Skip to content

Commit

Permalink
IB/ucm: Use stack variable 'base' in ib_ucm_add_one
Browse files Browse the repository at this point in the history
This change is not useful by itself, but sets us up for a future
change that allows us to support more than IB_UCM_MAX_DEVICES.

Signed-off-by: Alex Chiang <achiang@hp.com>
Signed-off-by: Roland Dreier <rolandd@cisco.com>
  • Loading branch information
Alexander Chiang authored and Roland Dreier committed Feb 24, 2010
1 parent dd08f70 commit 31d14b6
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion drivers/infiniband/core/ucm.c
Original file line number Diff line number Diff line change
Expand Up @@ -1240,6 +1240,7 @@ static DEVICE_ATTR(ibdev, S_IRUGO, show_ibdev, NULL);
static void ib_ucm_add_one(struct ib_device *device)
{
int devnum;
dev_t base;
struct ib_ucm_device *ucm_dev;

if (!device->alloc_ucontext ||
Expand All @@ -1257,12 +1258,13 @@ static void ib_ucm_add_one(struct ib_device *device)
goto err;

ucm_dev->devnum = devnum;
base = devnum + IB_UCM_BASE_DEV;
set_bit(devnum, dev_map);

cdev_init(&ucm_dev->cdev, &ucm_fops);
ucm_dev->cdev.owner = THIS_MODULE;
kobject_set_name(&ucm_dev->cdev.kobj, "ucm%d", ucm_dev->devnum);
if (cdev_add(&ucm_dev->cdev, IB_UCM_BASE_DEV + devnum, 1))
if (cdev_add(&ucm_dev->cdev, base, 1))
goto err;

ucm_dev->dev.class = &cm_class;
Expand Down

0 comments on commit 31d14b6

Please sign in to comment.