Skip to content

Commit

Permalink
pvops: do not notify callers from register_xenstore_notifier
Browse files Browse the repository at this point in the history
Currently register_xenstore_notifier notifies the caller during the
registration itself if xenstore is believed to be ready. This behaviour
causes problems to PV on HVM guests, in which case callers should be
notified by xenbus_probe only after the platform pci driver is loaded.
We already make sure xenbus_probe is called at the right time, calling
it either from device_initcall (PV case) or from the platform pci
driver initialization (HVM case) so we don't need this additional
notification.

Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
  • Loading branch information
Stefano Stabellini authored and Jeremy Fitzhardinge committed Aug 4, 2010
1 parent f89e048 commit 31de189
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions drivers/xen/xenbus/xenbus_probe.c
Original file line number Diff line number Diff line change
Expand Up @@ -752,10 +752,7 @@ int register_xenstore_notifier(struct notifier_block *nb)
{
int ret = 0;

if (xenstored_ready > 0)
ret = nb->notifier_call(nb, 0, NULL);
else
blocking_notifier_chain_register(&xenstore_chain, nb);
blocking_notifier_chain_register(&xenstore_chain, nb);

return ret;
}
Expand Down

0 comments on commit 31de189

Please sign in to comment.