Skip to content

Commit

Permalink
ps3disk: Remove superfluous cast
Browse files Browse the repository at this point in the history
As ps3disk is a ppc64-only driver, sector_t equals to unsigned long, and the
cast is not needed.

Reuse in another (possibly 32-bit) driver is protected by the safety net called
`compiler warning' (with the cast, it may silently truncate to 32-bit).
If sector_t ever changes, we will get a compiler warning as well (with the
cast, we won't).

Signed-off-by: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>
Acked-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
  • Loading branch information
Geert Uytterhoeven authored and Jens Axboe committed Apr 29, 2008
1 parent 1afb20f commit 31e103c
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions drivers/block/ps3disk.c
Original file line number Diff line number Diff line change
Expand Up @@ -102,8 +102,7 @@ static void ps3disk_scatter_gather(struct ps3_storage_device *dev,
dev_dbg(&dev->sbd.core,
"%s:%u: bio %u: %u segs %u sectors from %lu\n",
__func__, __LINE__, i, bio_segments(iter.bio),
bio_sectors(iter.bio),
(unsigned long)iter.bio->bi_sector);
bio_sectors(iter.bio), iter.bio->bi_sector);

size = bvec->bv_len;
buf = bvec_kmap_irq(bvec, &flags);
Expand Down

0 comments on commit 31e103c

Please sign in to comment.