Skip to content

Commit

Permalink
arch/tile: Fix a couple of issues with the COMPAT code for TILE-Gx.
Browse files Browse the repository at this point in the history
First, the siginfo preamble wasn't quite right; we need to indicate
that we are padding up to 4 ints of preamble for 64-bit code, and
then for compat mode we need to pad differently, using only 3 ints.

Second, the C ABI requires a save area of two registers, not two
pointers, since in compat mode we have 64-bit registers all of which
we need to save, even though we only have 32-bit VAs.

Signed-off-by: Chris Metcalf <cmetcalf@tilera.com>
  • Loading branch information
Chris Metcalf committed Aug 13, 2010
1 parent 749dc6f commit 32020ef
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 4 deletions.
4 changes: 1 addition & 3 deletions arch/tile/include/arch/abi.h
Original file line number Diff line number Diff line change
Expand Up @@ -59,9 +59,7 @@
* The ABI requires callers to allocate a caller state save area of
* this many bytes at the bottom of each stack frame.
*/
#ifdef __tile__
#define C_ABI_SAVE_AREA_SIZE (2 * __SIZEOF_POINTER__)
#endif
#define C_ABI_SAVE_AREA_SIZE (2 * (CHIP_WORD_SIZE() / 8))

/**
* The operand to an 'info' opcode directing the backtracer to not
Expand Down
4 changes: 4 additions & 0 deletions arch/tile/include/asm/siginfo.h
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,10 @@

#define __ARCH_SI_TRAPNO

#ifdef __LP64__
# define __ARCH_SI_PREAMBLE_SIZE (4 * sizeof(int))
#endif

#include <asm-generic/siginfo.h>

/*
Expand Down
4 changes: 3 additions & 1 deletion arch/tile/kernel/compat_signal.c
Original file line number Diff line number Diff line change
Expand Up @@ -56,13 +56,15 @@ struct compat_ucontext {
sigset_t uc_sigmask; /* mask last for extensibility */
};

#define COMPAT_SI_PAD_SIZE ((SI_MAX_SIZE - 3 * sizeof(int)) / sizeof(int))

struct compat_siginfo {
int si_signo;
int si_errno;
int si_code;

union {
int _pad[SI_PAD_SIZE];
int _pad[COMPAT_SI_PAD_SIZE];

/* kill() */
struct {
Expand Down

0 comments on commit 32020ef

Please sign in to comment.