Skip to content

Commit

Permalink
perf, x86: Restrict the ANY flag
Browse files Browse the repository at this point in the history
The ANY flag can show SMT data of another task (like 'top'),
so we want to disable it when system-wide profiling is
disabled.

Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
LKML-Reference: <new-submission>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
  • Loading branch information
Peter Zijlstra authored and Ingo Molnar committed Mar 2, 2010
1 parent bb1165d commit 320ebf0
Show file tree
Hide file tree
Showing 3 changed files with 18 additions and 15 deletions.
3 changes: 3 additions & 0 deletions arch/x86/kernel/cpu/perf_event.c
Original file line number Diff line number Diff line change
Expand Up @@ -503,6 +503,9 @@ static int __hw_perf_event_init(struct perf_event *event)
*/
if (attr->type == PERF_TYPE_RAW) {
hwc->config |= x86_pmu.raw_event(attr->config);
if ((hwc->config & ARCH_PERFMON_EVENTSEL_ANY) &&
perf_paranoid_cpu() && !capable(CAP_SYS_ADMIN))
return -EACCES;
return 0;
}

Expand Down
15 changes: 15 additions & 0 deletions include/linux/perf_event.h
Original file line number Diff line number Diff line change
Expand Up @@ -857,6 +857,21 @@ extern int sysctl_perf_event_paranoid;
extern int sysctl_perf_event_mlock;
extern int sysctl_perf_event_sample_rate;

static inline bool perf_paranoid_tracepoint_raw(void)
{
return sysctl_perf_event_paranoid > -1;
}

static inline bool perf_paranoid_cpu(void)
{
return sysctl_perf_event_paranoid > 0;
}

static inline bool perf_paranoid_kernel(void)
{
return sysctl_perf_event_paranoid > 1;
}

extern void perf_event_init(void);
extern void perf_tp_event(int event_id, u64 addr, u64 count, void *record, int entry_size);
extern void perf_bp_event(struct perf_event *event, void *data);
Expand Down
15 changes: 0 additions & 15 deletions kernel/perf_event.c
Original file line number Diff line number Diff line change
Expand Up @@ -56,21 +56,6 @@ static atomic_t nr_task_events __read_mostly;
*/
int sysctl_perf_event_paranoid __read_mostly = 1;

static inline bool perf_paranoid_tracepoint_raw(void)
{
return sysctl_perf_event_paranoid > -1;
}

static inline bool perf_paranoid_cpu(void)
{
return sysctl_perf_event_paranoid > 0;
}

static inline bool perf_paranoid_kernel(void)
{
return sysctl_perf_event_paranoid > 1;
}

int sysctl_perf_event_mlock __read_mostly = 512; /* 'free' kb per user */

/*
Expand Down

0 comments on commit 320ebf0

Please sign in to comment.