Skip to content

Commit

Permalink
nilfs2: fix potential leak of dirty data on umount
Browse files Browse the repository at this point in the history
This fixes incorrect usage of nilfs_segctor_confirm() test function in
nilfs_segctor_destroy(); nilfs_segctor_confirm() returns zero if the
filesystem is not clean, so its use in nilfs_segctor_destroy() needs
inversion.

Signed-off-by: Ryusuke Konishi <konishi.ryusuke@lab.ntt.co.jp>
  • Loading branch information
Ryusuke Konishi committed Jan 31, 2010
1 parent abe94c7 commit 3256a05
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion fs/nilfs2/segment.c
Original file line number Diff line number Diff line change
Expand Up @@ -2829,7 +2829,7 @@ static void nilfs_segctor_destroy(struct nilfs_sc_info *sci)
|| sci->sc_seq_request != sci->sc_seq_done);
spin_unlock(&sci->sc_state_lock);

if (flag || nilfs_segctor_confirm(sci))
if (flag || !nilfs_segctor_confirm(sci))
nilfs_segctor_write_out(sci);

WARN_ON(!list_empty(&sci->sc_copied_buffers));
Expand Down

0 comments on commit 3256a05

Please sign in to comment.