Skip to content

Commit

Permalink
regulator: tps6586x-regulator - fix value range checking for val
Browse files Browse the repository at this point in the history
val is used as array index of ri->voltages.
Thus the valid value range should be 0 .. ri->desc.n_voltages - 1.

Signed-off-by: Axel Lin <axel.lin@gmail.com>
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Signed-off-by: Liam Girdwood <lrg@slimlogic.co.uk>
  • Loading branch information
Axel Lin authored and Liam Girdwood committed Sep 1, 2010
1 parent c356cbc commit 327531b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/regulator/tps6586x-regulator.c
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ static int tps6586x_ldo_get_voltage(struct regulator_dev *rdev)
mask = ((1 << ri->volt_nbits) - 1) << ri->volt_shift;
val = (val & mask) >> ri->volt_shift;

if (val > ri->desc.n_voltages)
if (val >= ri->desc.n_voltages)
BUG();

return ri->voltages[val] * 1000;
Expand Down

0 comments on commit 327531b

Please sign in to comment.