Skip to content

Commit

Permalink
V4L/DVB (11067): au0828: workaround a bug in the au0828 i2c handling
Browse files Browse the repository at this point in the history
There is an issue related to the i2c clock for addressing the xc5000.  The
au0828 chip does not support clock stretching, which the xc5000 makes use of.
This results in cases where we silently get back garbage in i2c read
operations.  To work around this issue until we slow down the i2c clock when
talking with that specific device.

This was not an issue before we had analog support because we never needed to
enumerate the i2c bus, and digital tuning never actually needed to perform
read operations against the xc5000.

Thanks to Michael Krufky <mkrufky@linuxtv.org> and Steven Toth
<stoth@linuxtv.org> for providing sample hardware, engineering level support,
and testing.

Signed-off-by: Devin Heitmueller <dheitmueller@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
  • Loading branch information
Devin Heitmueller authored and Mauro Carvalho Chehab committed Mar 30, 2009
1 parent 8b2f079 commit 32c000a
Showing 1 changed file with 20 additions and 2 deletions.
22 changes: 20 additions & 2 deletions drivers/media/video/au0828/au0828-i2c.c
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,16 @@ static int i2c_sendbytes(struct i2c_adapter *i2c_adap,
dprintk(4, "%s()\n", __func__);

au0828_write(dev, REG_2FF, 0x01);
au0828_write(dev, REG_202, 0x07);

/* FIXME: There is a problem with i2c communications with xc5000 that
requires us to slow down the i2c clock until we have a better
strategy (such as using the secondary i2c bus to do firmware
loading */
if ((msg->addr << 1) == 0xc2) {
au0828_write(dev, REG_202, 0x40);
} else {
au0828_write(dev, REG_202, 0x07);
}

/* Hardware needs 8 bit addresses */
au0828_write(dev, REG_203, msg->addr << 1);
Expand Down Expand Up @@ -191,7 +200,16 @@ static int i2c_readbytes(struct i2c_adapter *i2c_adap,
dprintk(4, "%s()\n", __func__);

au0828_write(dev, REG_2FF, 0x01);
au0828_write(dev, REG_202, 0x07);

/* FIXME: There is a problem with i2c communications with xc5000 that
requires us to slow down the i2c clock until we have a better
strategy (such as using the secondary i2c bus to do firmware
loading */
if ((msg->addr << 1) == 0xc2) {
au0828_write(dev, REG_202, 0x40);
} else {
au0828_write(dev, REG_202, 0x07);
}

/* Hardware needs 8 bit addresses */
au0828_write(dev, REG_203, msg->addr << 1);
Expand Down

0 comments on commit 32c000a

Please sign in to comment.