Skip to content

Commit

Permalink
videomode: create enum for videomode's display flags
Browse files Browse the repository at this point in the history
Instead of having plain defines for the videomode's flags, add an enum
for the flags. This makes the flags clearer to use, as the enum tells
which values can be used with the flags field.

Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: Steffen Trumtrar <s.trumtrar@pengutronix.de>
  • Loading branch information
Tomi Valkeinen committed Mar 12, 2013
1 parent 06a3307 commit 32ed6ef
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 12 deletions.
28 changes: 17 additions & 11 deletions include/video/display_timing.h
Original file line number Diff line number Diff line change
Expand Up @@ -12,16 +12,22 @@
#include <linux/bitops.h>
#include <linux/types.h>

#define DISPLAY_FLAGS_HSYNC_LOW BIT(0)
#define DISPLAY_FLAGS_HSYNC_HIGH BIT(1)
#define DISPLAY_FLAGS_VSYNC_LOW BIT(2)
#define DISPLAY_FLAGS_VSYNC_HIGH BIT(3)
#define DISPLAY_FLAGS_DE_LOW BIT(4) /* data enable flag */
#define DISPLAY_FLAGS_DE_HIGH BIT(5)
#define DISPLAY_FLAGS_PIXDATA_POSEDGE BIT(6) /* drive data on pos. edge */
#define DISPLAY_FLAGS_PIXDATA_NEGEDGE BIT(7) /* drive data on neg. edge */
#define DISPLAY_FLAGS_INTERLACED BIT(8)
#define DISPLAY_FLAGS_DOUBLESCAN BIT(9)
enum display_flags {
DISPLAY_FLAGS_HSYNC_LOW = BIT(0),
DISPLAY_FLAGS_HSYNC_HIGH = BIT(1),
DISPLAY_FLAGS_VSYNC_LOW = BIT(2),
DISPLAY_FLAGS_VSYNC_HIGH = BIT(3),

/* data enable flag */
DISPLAY_FLAGS_DE_LOW = BIT(4),
DISPLAY_FLAGS_DE_HIGH = BIT(5),
/* drive data on pos. edge */
DISPLAY_FLAGS_PIXDATA_POSEDGE = BIT(6),
/* drive data on neg. edge */
DISPLAY_FLAGS_PIXDATA_NEGEDGE = BIT(7),
DISPLAY_FLAGS_INTERLACED = BIT(8),
DISPLAY_FLAGS_DOUBLESCAN = BIT(9),
};

/*
* A single signal can be specified via a range of minimal and maximal values
Expand Down Expand Up @@ -69,7 +75,7 @@ struct display_timing {
struct timing_entry vback_porch; /* ver. back porch */
struct timing_entry vsync_len; /* ver. sync len */

unsigned int flags; /* display flags */
enum display_flags flags; /* display flags */
};

/*
Expand Down
2 changes: 1 addition & 1 deletion include/video/videomode.h
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ struct videomode {
u32 vback_porch;
u32 vsync_len;

unsigned int flags; /* display flags */
enum display_flags flags; /* display flags */
};

/**
Expand Down

0 comments on commit 32ed6ef

Please sign in to comment.