Skip to content

Commit

Permalink
[IPV6]: Replace bogus instances of inet->recverr
Browse files Browse the repository at this point in the history
While looking at this problem I noticed that IPv6 was sometimes
looking at inet->recverr which is bogus.  Here is a patch to
correct that and use np->recverr.
 
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Acked-by: Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Herbert Xu authored and David S. Miller committed Apr 20, 2005
1 parent 357b40a commit 3320da8
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 5 deletions.
2 changes: 1 addition & 1 deletion net/ipv6/ip6_output.c
Original file line number Diff line number Diff line change
Expand Up @@ -1149,7 +1149,7 @@ int ip6_push_pending_frames(struct sock *sk)
err = NF_HOOK(PF_INET6, NF_IP6_LOCAL_OUT, skb, NULL, skb->dst->dev, dst_output);
if (err) {
if (err > 0)
err = inet->recverr ? net_xmit_errno(err) : 0;
err = np->recverr ? net_xmit_errno(err) : 0;
if (err)
goto error;
}
Expand Down
6 changes: 2 additions & 4 deletions net/ipv6/raw.c
Original file line number Diff line number Diff line change
Expand Up @@ -533,7 +533,7 @@ static int rawv6_send_hdrinc(struct sock *sk, void *from, int length,
struct flowi *fl, struct rt6_info *rt,
unsigned int flags)
{
struct inet_sock *inet = inet_sk(sk);
struct ipv6_pinfo *np = inet6_sk(sk);
struct ipv6hdr *iph;
struct sk_buff *skb;
unsigned int hh_len;
Expand Down Expand Up @@ -570,7 +570,7 @@ static int rawv6_send_hdrinc(struct sock *sk, void *from, int length,
err = NF_HOOK(PF_INET6, NF_IP6_LOCAL_OUT, skb, NULL, rt->u.dst.dev,
dst_output);
if (err > 0)
err = inet->recverr ? net_xmit_errno(err) : 0;
err = np->recverr ? net_xmit_errno(err) : 0;
if (err)
goto error;
out:
Expand Down Expand Up @@ -807,8 +807,6 @@ static int rawv6_sendmsg(struct kiocb *iocb, struct sock *sk,
ip6_dst_store(sk, dst,
ipv6_addr_equal(&fl.fl6_dst, &np->daddr) ?
&np->daddr : NULL);
if (err > 0)
err = np->recverr ? net_xmit_errno(err) : 0;

release_sock(sk);
out:
Expand Down

0 comments on commit 3320da8

Please sign in to comment.