Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 26193
b: refs/heads/master
c: d27ed38
h: refs/heads/master
i:
  26191: 68e0fcb
v: v3
  • Loading branch information
Stephen Hemminger authored and Jeff Garzik committed Apr 26, 2006
1 parent 2469e98 commit 3321510
Show file tree
Hide file tree
Showing 3 changed files with 24 additions and 2 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: 734cbc363b159caee158d5a83408c72d98bcacf0
refs/heads/master: d27ed38765d6e01eaab443a7909f53a37f090e99
22 changes: 21 additions & 1 deletion trunk/drivers/net/sky2.c
Original file line number Diff line number Diff line change
Expand Up @@ -2086,6 +2086,20 @@ static void sky2_descriptor_error(struct sky2_hw *hw, unsigned port,
}
}

/* If idle then force a fake soft NAPI poll once a second
* to work around cases where sharing an edge triggered interrupt.
*/
static void sky2_idle(unsigned long arg)
{
struct net_device *dev = (struct net_device *) arg;

local_irq_disable();
if (__netif_rx_schedule_prep(dev))
__netif_rx_schedule(dev);
local_irq_enable();
}


static int sky2_poll(struct net_device *dev0, int *budget)
{
struct sky2_hw *hw = ((struct sky2_port *) netdev_priv(dev0))->hw;
Expand Down Expand Up @@ -2134,6 +2148,8 @@ static int sky2_poll(struct net_device *dev0, int *budget)
sky2_write32(hw, STAT_CTRL, SC_STAT_CLR_IRQ);
}

mod_timer(&hw->idle_timer, jiffies + HZ);

local_irq_disable();
__netif_rx_complete(dev0);

Expand Down Expand Up @@ -3288,6 +3304,8 @@ static int __devinit sky2_probe(struct pci_dev *pdev,

sky2_write32(hw, B0_IMSK, Y2_IS_BASE);

setup_timer(&hw->idle_timer, sky2_idle, (unsigned long) dev);

pci_set_drvdata(pdev, hw);

return 0;
Expand Down Expand Up @@ -3323,13 +3341,15 @@ static void __devexit sky2_remove(struct pci_dev *pdev)
if (!hw)
return;

del_timer_sync(&hw->idle_timer);

sky2_write32(hw, B0_IMSK, 0);
dev0 = hw->dev[0];
dev1 = hw->dev[1];
if (dev1)
unregister_netdev(dev1);
unregister_netdev(dev0);

sky2_write32(hw, B0_IMSK, 0);
sky2_set_power_state(hw, PCI_D3hot);
sky2_write16(hw, B0_Y2LED, LED_STAT_OFF);
sky2_write8(hw, B0_CTST, CS_RST_SET);
Expand Down
2 changes: 2 additions & 0 deletions trunk/drivers/net/sky2.h
Original file line number Diff line number Diff line change
Expand Up @@ -1880,6 +1880,8 @@ struct sky2_hw {
struct sky2_status_le *st_le;
u32 st_idx;
dma_addr_t st_dma;

struct timer_list idle_timer;
int msi_detected;
wait_queue_head_t msi_wait;
};
Expand Down

0 comments on commit 3321510

Please sign in to comment.