Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 205778
b: refs/heads/master
c: 3d550fb
h: refs/heads/master
v: v3
  • Loading branch information
Jonathan Cameron authored and Greg Kroah-Hartman committed Jul 8, 2010
1 parent 16660c0 commit 332db71
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 26 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: 1980e4ac3a62e42a3db56185f9bd01a0e40dfe55
refs/heads/master: 3d550fbace94a79b97cde94dca46f5477c817fed
3 changes: 0 additions & 3 deletions trunk/drivers/staging/iio/chrdev.h
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,6 @@ struct iio_shared_ev_pointer {
* @det_events: list of detected events
* @max_events: maximum number of events before new ones are dropped
* @current_events: number of events in detected list
* @id: indentifier to allow the event interface to know which
* physical line it corresponds to
* @attr: this chrdev's minor number sysfs attribute
* @owner: ensure the driver module owns the file, not iio
* @private: driver specific data
Expand All @@ -90,7 +88,6 @@ struct iio_event_interface {
struct iio_detected_event_list det_events;
int max_events;
int current_events;
int id;
struct iio_chrdev_minor_attr attr;
struct module *owner;
void *private;
Expand Down
22 changes: 3 additions & 19 deletions trunk/drivers/staging/iio/industrialio-core.c
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,6 @@

/* IDR to assign each registered device a unique id*/
static DEFINE_IDR(iio_idr);

/* IDR for general event identifiers */
static DEFINE_IDR(iio_event_idr);
/* IDR to allocate character device minor numbers */
static DEFINE_IDR(iio_chrdev_idr);
/* Lock used to protect both of the above */
Expand Down Expand Up @@ -654,16 +651,11 @@ static int iio_device_register_eventset(struct iio_dev *dev_info)

for (i = 0; i < dev_info->num_interrupt_lines; i++) {
dev_info->event_interfaces[i].owner = dev_info->driver_module;
ret = iio_get_new_idr_val(&iio_event_idr);
if (ret < 0)
goto error_free_setup_ev_ints;
else
dev_info->event_interfaces[i].id = ret;

snprintf(dev_info->event_interfaces[i]._name, 20,
"%s:event%d",
dev_name(&dev_info->dev),
dev_info->event_interfaces[i].id);
i);

ret = iio_setup_ev_int(&dev_info->event_interfaces[i],
(const char *)(dev_info
Expand All @@ -674,8 +666,6 @@ static int iio_device_register_eventset(struct iio_dev *dev_info)
if (ret) {
dev_err(&dev_info->dev,
"Could not get chrdev interface\n");
iio_free_idr_val(&iio_event_idr,
dev_info->event_interfaces[i].id);
goto error_free_setup_ev_ints;
}

Expand Down Expand Up @@ -711,11 +701,8 @@ static int iio_device_register_eventset(struct iio_dev *dev_info)
->event_interfaces[j].dev.kobj,
&dev_info->event_attrs[j]);
error_free_setup_ev_ints:
for (j = 0; j < i; j++) {
iio_free_idr_val(&iio_event_idr,
dev_info->event_interfaces[j].id);
for (j = 0; j < i; j++)
iio_free_ev_int(&dev_info->event_interfaces[j]);
}
kfree(dev_info->interrupts);
error_free_event_interfaces:
kfree(dev_info->event_interfaces);
Expand All @@ -735,11 +722,8 @@ static void iio_device_unregister_eventset(struct iio_dev *dev_info)
->event_interfaces[i].dev.kobj,
&dev_info->event_attrs[i]);

for (i = 0; i < dev_info->num_interrupt_lines; i++) {
iio_free_idr_val(&iio_event_idr,
dev_info->event_interfaces[i].id);
for (i = 0; i < dev_info->num_interrupt_lines; i++)
iio_free_ev_int(&dev_info->event_interfaces[i]);
}
kfree(dev_info->interrupts);
kfree(dev_info->event_interfaces);
}
Expand Down
4 changes: 1 addition & 3 deletions trunk/drivers/staging/iio/industrialio-ring.c
Original file line number Diff line number Diff line change
Expand Up @@ -149,12 +149,10 @@ __iio_request_ring_buffer_event_chrdev(struct iio_ring_buffer *buf,
{
int ret;

buf->ev_int.id = id;

snprintf(buf->ev_int._name, sizeof(buf->ev_int._name),
"%s:event%d",
dev_name(&buf->dev),
buf->ev_int.id);
id);
ret = iio_setup_ev_int(&(buf->ev_int),
buf->ev_int._name,
owner,
Expand Down

0 comments on commit 332db71

Please sign in to comment.