Skip to content

Commit

Permalink
[ARM] Move ISA DMA bus_to_virt() out of set_dma_addr()
Browse files Browse the repository at this point in the history
Allow the compiler to optimise the bus_to_virt(virt_to_bus())
transformation in the ARM ISA DMA interface.

Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
  • Loading branch information
Russell King authored and Russell King committed Jan 4, 2006
1 parent 109a937 commit 333c962
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 5 deletions.
8 changes: 4 additions & 4 deletions arch/arm/kernel/dma.c
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ void set_dma_sg (dmach_t channel, struct scatterlist *sg, int nr_sg)
*
* Copy address to the structure, and set the invalid bit
*/
void set_dma_addr (dmach_t channel, unsigned long physaddr)
void __set_dma_addr (dmach_t channel, void *addr)
{
dma_t *dma = dma_chan + channel;

Expand All @@ -141,7 +141,7 @@ void set_dma_addr (dmach_t channel, unsigned long physaddr)

dma->sg = &dma->buf;
dma->sgcount = 1;
dma->buf.__address = bus_to_virt(physaddr);
dma->buf.__address = addr;
dma->using_sg = 0;
dma->invalid = 1;
}
Expand Down Expand Up @@ -278,7 +278,7 @@ GLOBAL_ALIAS(get_dma_list, get_dma_residue);
GLOBAL_ALIAS(set_dma_mode, get_dma_residue);
GLOBAL_ALIAS(set_dma_page, get_dma_residue);
GLOBAL_ALIAS(set_dma_count, get_dma_residue);
GLOBAL_ALIAS(set_dma_addr, get_dma_residue);
GLOBAL_ALIAS(__set_dma_addr, get_dma_residue);
GLOBAL_ALIAS(set_dma_sg, get_dma_residue);
GLOBAL_ALIAS(set_dma_speed, get_dma_residue);
GLOBAL_ALIAS(init_dma, get_dma_residue);
Expand All @@ -289,7 +289,7 @@ EXPORT_SYMBOL(request_dma);
EXPORT_SYMBOL(free_dma);
EXPORT_SYMBOL(enable_dma);
EXPORT_SYMBOL(disable_dma);
EXPORT_SYMBOL(set_dma_addr);
EXPORT_SYMBOL(__set_dma_addr);
EXPORT_SYMBOL(set_dma_count);
EXPORT_SYMBOL(set_dma_mode);
EXPORT_SYMBOL(set_dma_page);
Expand Down
4 changes: 3 additions & 1 deletion include/asm-arm/dma.h
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,9 @@ extern void set_dma_sg(dmach_t channel, struct scatterlist *sg, int nr_sg);
* especially since some DMA architectures don't update the
* DMA address immediately, but defer it to the enable_dma().
*/
extern void set_dma_addr(dmach_t channel, unsigned long physaddr);
extern void __set_dma_addr(dmach_t channel, void *addr);
#define set_dma_addr(channel, addr) \
__set_dma_addr(channel, bus_to_virt(addr))

/* Set the DMA byte count for this channel
*
Expand Down

0 comments on commit 333c962

Please sign in to comment.