Skip to content

Commit

Permalink
[PATCH] Remove redundant check from autofs4_put_super
Browse files Browse the repository at this point in the history
We have to have a valid sbi here, or we'd have oopsed already.  (There's a
dereference of sbi->catatonic a few lines above)

Coverity #740

Signed-off-by: Dave Jones <davej@redhat.com>
Cc: Ian Kent <raven@themaw.net>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
Dave Jones authored and Linus Torvalds committed Mar 27, 2006
1 parent 44d53eb commit 3370c74
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions fs/autofs4/inode.c
Original file line number Diff line number Diff line change
Expand Up @@ -157,8 +157,7 @@ static void autofs4_put_super(struct super_block *sb)
autofs4_catatonic_mode(sbi); /* Free wait queues, close pipe */

/* Clean up and release dangling references */
if (sbi)
autofs4_force_release(sbi);
autofs4_force_release(sbi);

kfree(sbi);

Expand Down

0 comments on commit 3370c74

Please sign in to comment.