Skip to content

Commit

Permalink
brcm80211: fmac: move module init/exit to sdio layer
Browse files Browse the repository at this point in the history
This patch is part of the fullmac bus interface refactoring series.
It moves the module init/exit code to bus layer.

Reviewed-by: Pieter-Paul Giesberts <pieterpg@broadcom.com>
Reviewed-by: Alwin Beukers <alwin@broadcom.com>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
  • Loading branch information
Franky Lin authored and John W. Linville committed Nov 28, 2011
1 parent 0c094c7 commit 3392c88
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 37 deletions.
19 changes: 14 additions & 5 deletions drivers/net/wireless/brcm80211/brcmfmac/bcmsdh_sdmmc.c
Original file line number Diff line number Diff line change
Expand Up @@ -577,17 +577,26 @@ static struct sdio_driver brcmf_sdmmc_driver = {
#endif /* CONFIG_PM_SLEEP */
};

/* bus register interface */
int brcmf_bus_register(void)
static void __exit brcmf_sdio_exit(void)
{
brcmf_dbg(TRACE, "Enter\n");

return sdio_register_driver(&brcmf_sdmmc_driver);
sdio_unregister_driver(&brcmf_sdmmc_driver);
}

void brcmf_bus_unregister(void)
static int __init brcmf_sdio_init(void)
{
int ret;

brcmf_dbg(TRACE, "Enter\n");

sdio_unregister_driver(&brcmf_sdmmc_driver);
ret = sdio_register_driver(&brcmf_sdmmc_driver);

if (ret)
brcmf_dbg(ERROR, "sdio_register_driver failed: %d\n", ret);

return ret;
}

module_init(brcmf_sdio_init);
module_exit(brcmf_sdio_exit);
4 changes: 0 additions & 4 deletions drivers/net/wireless/brcm80211/brcmfmac/dhd_bus.h
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,6 @@
* Exported from brcmf bus module (brcmf_usb, brcmf_sdio)
*/

/* Indicate (dis)interest in finding dongles. */
extern int brcmf_bus_register(void);
extern void brcmf_bus_unregister(void);

/* obtain linux device object providing bus function */
extern struct device *brcmf_bus_get_device(struct brcmf_bus *bus);

Expand Down
28 changes: 0 additions & 28 deletions drivers/net/wireless/brcm80211/brcmfmac/dhd_linux.c
Original file line number Diff line number Diff line change
Expand Up @@ -1147,34 +1147,6 @@ void brcmf_detach(struct brcmf_pub *drvr)
}
}

static void __exit brcmf_module_cleanup(void)
{
brcmf_dbg(TRACE, "Enter\n");

brcmf_bus_unregister();
}

static int __init brcmf_module_init(void)
{
int error;

brcmf_dbg(TRACE, "Enter\n");

error = brcmf_bus_register();

if (error) {
brcmf_dbg(ERROR, "brcmf_bus_register failed\n");
goto failed;
}
return 0;

failed:
return -EINVAL;
}

module_init(brcmf_module_init);
module_exit(brcmf_module_cleanup);

int brcmf_os_proto_block(struct brcmf_pub *drvr)
{
struct brcmf_info *drvr_priv = drvr->info;
Expand Down

0 comments on commit 3392c88

Please sign in to comment.